Description Sebastien Dubois 2010-11-11 11:34:31 EST

The selectChange method in CompareEditorInputNavigator does not behave properly when it is called initially with false as input.  What should really happen is that is returns false (since initially the first change selected is always the first one, but should work correctly afterwards.

Right now a DebugException is generated and the selection index goes out of sync.  So later on when slectChange is called with true as input, the next change is not selected properly.

The affec5ed method shows this:

	/* (non-Javadoc)
	 * @see org.eclipse.compare.ICompareNavigator#selectChange(boolean)
	 */
	public boolean selectChange(boolean next) {
		// Fix for http://dev.eclipse.org/bugs/show_bug.cgi?id=20106
		if (next && fNextFirstTime && mustOpen()) {
			fNextFirstTime= false;
			if (openElement())
				return false;
		}
		return super.selectChange(next);
	}

I think the problem happens because the navigator input is not loaded when the input is set to false (the first "if (next...)" ).  I think the element should be opened regardless of the value of the input parameter.