Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330011 - [Slider] Split "Slider" to have a "AbstractSlider"
Summary: [Slider] Split "Slider" to have a "AbstractSlider"
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 314763
  Show dependency tree
 
Reported: 2010-11-11 11:10 EST by Tim Buschtoens CLA
Modified: 2010-11-26 10:29 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2010-11-11 11:10:57 EST 
Split "Slider" into "BasicSlider" and "Slider". BasicSlider can then be used as a superclass for ScrollBar. Of course first a SliderTest has to be written.
Comment 1 Tim Buschtoens CLA 2010-11-16 04:37:55 EST 
We don't actually need a BasicSlider, an abstract class will do just fine..,
Comment 2 Tim Buschtoens CLA 2010-11-26 10:29:09 EST 
Fixed in CVS HEAD.

I also took the oppurtunity to refactor the resulting AbstractSlider in some aspects:

- Changed formatting in some cases to better match our coding-conventions.
- Renamed some variables for better legibility.
- Reduced size by extracting helper-functions.
- Removed the "line" widget which was not necessary.