Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329993 - Better logging for J2EEModelProviderRegistry
Summary: Better logging for J2EEModelProviderRegistry
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Server 2003
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Jason Sholl CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-11 08:30 EST by Jason Sholl CLA
Modified: 2010-11-17 09:51 EST (History)
0 users

See Also:
cbridgha: review+

Attachments
patch (2.94 KB, patch)
2010-11-11 08:32 EST, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2010-11-11 08:30:45 EST 
J2EEModelProviderRegistry needs slightly better error logging to report the offending extension details so bad extensions can be quickly identified.

Instead of logging a message like this followed by the exception which caused it:

!ENTRY org.eclipse.jst.j2ee 4 0 2010-11-11 08:04:22.921
!MESSAGE Unrecognized facet: jst.ear2

The following will now be logged followed by the exception which caused it:

!ENTRY org.eclipse.jst.j2ee 4 0 2010-11-11 08:29:11.703
!MESSAGE Plugin org.eclipse.jst.jee, extension org.eclipse.jst.j2ee.J2EEModelProvider
Unrecognized facet: jst.ear2
Comment 1 Jason Sholl CLA 2010-11-11 08:32:52 EST 
Created attachment 182897 [details]
patch
Comment 2 Jason Sholl CLA 2010-11-11 08:35:15 EST 
code checked into both 32M and HEAD for WTP 3.2.3 and 3.3
Comment 3 Chuck Bridgham CLA 2010-11-17 09:51:48 EST 
approved