Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329963 - Git toolbar needs care
Summary: Git toolbar needs care
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.10.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.10.0-M3   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 18:18 EST by Matthias Sohn CLA
Modified: 2010-12-02 02:58 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Sohn CLA 2010-11-10 18:18:11 EST
- tooltip texts are externalized but it seems the corresponding texts have disappeared, e.g.
the fetch button shows "%FetchAction_tooltip" as tooltip
- outdated icons should be updated to be consistent with icons in context menus
- check if additional commands should be exposed here
- [1] reported that "Add" button disappeared

[1] http://dev.eclipse.org/mhonarc/lists/egit-dev/msg01594.html
Comment 1 Matthias Sohn CLA 2010-11-25 17:29:19 EST
We now have two proposals how this could be fixed:

[1] using traditional actionset fixing the existing git toolbar and menu
     downside is that actions should rather be replaced by the more flexible command     
     framework
[2] using commands, this works on Mac in Helios, but it doesn't work on Windows in Galileo
     as long as team API uses actions we cannot completely get rid of actions framework.

Currently we are unsure what approach to follow.

[1] http://egit.eclipse.org/r/#change,1955
[2] http://egit.eclipse.org/r/#change,1941
Comment 2 Matthias Sohn CLA 2010-11-27 20:05:58 EST
merged a3c5194a9d77c190954d11a28fed40e2474f6ef9 fixing the Git toolbar and menu using the action based solution.

Will re-add the Add command in a subsequent change.
Comment 3 Matthias Sohn CLA 2010-11-29 11:34:28 EST
Pushed http://egit.eclipse.org/r/#change,1967 for review to add the AddToIndex operation to the Git Command Group actions.
Comment 4 Mathias Kinzler CLA 2010-12-02 02:58:45 EST
Merged as 308b1da4165b6c887b3c9b99bd424d799ebb4d6d