Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329914 - undefining environment variables for a remote C/C++ makefile project doesn't work
Summary: undefining environment variables for a remote C/C++ makefile project doesn't ...
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 4.0.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.0.5   Edit
Assignee: Chris Recoskie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 10:31 EST by Chris Recoskie CLA
Modified: 2010-11-10 11:46 EST (History)
2 users (show)

See Also:


Attachments
patch (1.30 KB, patch)
2010-11-10 10:36 EST, Chris Recoskie CLA
recoskie: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2010-11-10 10:31:44 EST
Go to the project properties->C/C++ Build->Environment property page, and undefine an environment variable.  The variable's original value from the shell is still passed to the remote process even though you theoretically undefined it.

There is some legacy code (copied from the CDT make builder - no longer used BTW) in the remote make builder checks the make info to see whether it should override the environment or just append to it.  Since the value never gets set to specify that the environment should be replaced, the code that clears out the remote environment so that the one specified by the user takes over entirely is never called.

The solution is to always clear the remote environment.  The list the user edited will have already contained the remote environment, so their edits should be fully respected.
Comment 1 Chris Recoskie CLA 2010-11-10 10:36:32 EST
Created attachment 182821 [details]
patch
Comment 2 Chris Recoskie CLA 2010-11-10 11:46:19 EST
Fixed on ptp_4_0 and HEAD