Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329835 - [EditorMgmt] WorkbenchEditorsDialog's save operation simply reuses a progress monitor repeatedly for every editor to be saved
Summary: [EditorMgmt] WorkbenchEditorsDialog's save operation simply reuses a progress...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-09 12:41 EST by Remy Suen CLA
Modified: 2010-12-07 08:09 EST (History)
0 users

See Also:

Attachments
WorkbenchEditorsDialog patch v1 (3.00 KB, patch)
2010-11-09 12:49 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-09 12:41:43 EST 
The progress monitor is passed to the editor's doSave(IProgressMonitor) without any regard for what the previous editor might've called on the editor.
Comment 1 Remy Suen CLA 2010-11-09 12:49:23 EST 
Created attachment 182737 [details]
WorkbenchEditorsDialog patch v1
Comment 2 Remy Suen CLA 2010-11-09 12:50:21 EST 
(In reply to comment #1)
> Created an attachment (id=182737) [details]
> WorkbenchEditorsDialog patch v1

Fix released to CVS HEAD.
Comment 3 Remy Suen CLA 2010-12-07 08:09:00 EST 
Verified by source code inspection with I20101206-1800 on Windows XP.