Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329806 - Don't unpack otdt.ui.help during installing
Summary: Don't unpack otdt.ui.help during installing
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: Releng (show other bugs)
Version: 0.7.1   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 0.8 M6   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-09 10:16 EST by Stephan Herrmann CLA
Modified: 2011-03-15 20:47 EDT (History)
0 users

See Also:

Attachments
fix (1.12 KB, patch)
2010-11-09 14:12 EST, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-11-09 10:16:03 EST 
For the simultaneous release all bundles should be installed with
'unpack="false"'.

However, when applying this to the otdt.ui.help plug-in, the OTJLD-view
cannot retrieve its content from the jar.

See http://www.eclipse.org/forums/index.php?t=msg&goto=637956
Comment 1 Stephan Herrmann CLA 2010-11-09 14:12:56 EST 
Created attachment 182754 [details]
fix

This tiny patch seems to do the trick (with a little help from Paul Webster):
- use FileLocator.toFileURL(m_url) to get a URL into extracted disk space AND
- use 
FileLocator.toFileURL(OTHelpPlugin.getDefault().getBundle().getEntry(OTJLDError.URL_PATH))
  to trigger extracting all content from this bundle
Comment 2 Stephan Herrmann CLA 2010-11-09 14:22:47 EST 
Fix released in r1009
Comment 3 Stephan Herrmann CLA 2010-11-11 11:18:05 EST 
Verified for 0.8 M3 using build 201011100445
Comment 4 Stephan Herrmann CLA 2011-03-12 17:13:50 EST 
I still saw missing content: OTJLD view did not show any images.
Comment 5 Stephan Herrmann CLA 2011-03-12 19:17:58 EST 
re-fixed in r1406/7 by touching also the css and images directories.
Comment 6 Stephan Herrmann CLA 2011-03-15 20:47:37 EDT 
Verified for 0.8M6 using build 201103151949.