Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329797 - Combo edition generation errors
Summary: Combo edition generation errors
Status: CLOSED FIXED
Alias: None
Product: EEF
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: ---   Edit
Assignee: EEF Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 328530 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-09 09:44 EST by William Piers CLA
Modified: 2016-05-05 10:26 EDT (History)
2 users (show)

See Also:


Attachments
a patch fixing the bug (872 bytes, patch)
2010-12-21 12:47 EST, William Piers CLA
goulwen.lefur: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Piers CLA 2010-11-09 09:44:33 EST
When choosing the "Combo widget" as the representation of an element editor, the generated code does not match the EEF runtime API. Here is the generated code:

element.setContentProvider(new EMFListContentProvider());

But EMFListContentProvider() constructor doesn't exists in the API (it takes a boolean parameter called "nullable").
Comment 1 William Piers CLA 2010-12-21 12:47:05 EST
Created attachment 185653 [details]
a patch fixing the bug

The attached patch fixes the bug (no more compilation errors after generation). I chose to add a constructor without parameters instead of changing the Acceleo file, because this way you will be able to later improve the generation and support this parameter.
With this implementation the nullable parameter is set to false by default.
Comment 2 Goulwen Le Fur CLA 2011-01-06 04:20:41 EST
Appliyed
Comment 3 Goulwen Le Fur CLA 2011-01-06 04:26:04 EST
*** Bug 328530 has been marked as a duplicate of this bug. ***