Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329728 - Enable CDT Disassembly view with TCF debugger
Summary: Enable CDT Disassembly view with TCF debugger
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.4.0   Edit
Assignee: Doug Schaefer CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 329729
  Show dependency tree
 
Reported: 2010-11-09 03:02 EST by Anton Leherbauer CLA
Modified: 2013-06-05 07:56 EDT (History)
1 user (show)

See Also:

Attachments
Add Disassembly view support for TCF (38.56 KB, patch)
2010-11-09 03:02 EST, Anton Leherbauer CLA 		cdtdoug: iplog+
Details | Diff
Force load of adapter (1.13 KB, patch)
2010-11-09 07:15 EST, Anton Leherbauer CLA 		cdtdoug: iplog+
Details | Diff
Patch take 2 (38.46 KB, patch)
2010-11-10 16:58 EST, Doug Schaefer CLA 		cdtdoug: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2010-11-09 03:02:24 EST 
Created attachment 182684 [details]
Add Disassembly view support for TCF

Attached patch adds support for using the CDT Disassembly view with the TCF debugger front-end.
Comment 1 Anton Leherbauer CLA 2010-11-09 07:15:46 EST 
Created attachment 182700 [details]
Force load of adapter

I just noticed that the adapter factory which creates the TCFDisassemblyBackend is not loaded if the org.eclipse.tm.tcf.cdt.ui plug-in is not yet activated.  This patch makes sure the factory is loaded anyway by forcing the adapter manager to activate the plug-in.
Comment 2 Doug Schaefer CLA 2010-11-10 12:59:12 EST 
Hi Toni. Is this the complete patch? There seems to be stuff missing.
Comment 3 Doug Schaefer CLA 2010-11-10 16:58:16 EST 
Created attachment 182854 [details]
Patch take 2
Comment 4 Doug Schaefer CLA 2010-11-10 16:59:53 EST 
I have applied the modified patch.
Comment 5 Doug Schaefer CLA 2010-11-10 17:01:42 EST 
Taking the assignment since I applied the patch.
Comment 6 Anton Leherbauer CLA 2010-11-11 02:01:08 EST 
(In reply to comment #2)
> Hi Toni. Is this the complete patch? There seems to be stuff missing.

Sorry, Subversive seems to have created the patch incorrectly.
Anyway, thanks for fixing it!
Comment 7 Martin Oberhuber CLA 2010-11-11 08:47:51 EST 
Hm... should Toni's contribution be iplog+ ? He is a CDT committer but not a TCF committer. See also his contribution on bug 329729 which Eugene placed an iplog+ on.
Comment 8 Doug Schaefer CLA 2010-11-11 13:22:00 EST 
Comment on attachment 182684 [details]
Add Disassembly view support for TCF

Yup, my bad. It doesn't need an IP review, but it should show up in the log.
Comment 9 Doug Schaefer CLA 2010-11-17 11:35:49 EST 
Comment on attachment 182700 [details]
Force load of adapter

I ended up applying this patch because Toni was right :).
Comment 10 Doug Schaefer CLA 2011-05-17 10:49:14 EDT 
Moving bugs to new home for IP log.
Comment 11 Martin Oberhuber CLA 2013-06-05 06:26:38 EDT 
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3