Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329722 - new features and products
Summary: new features and products
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 327724
  Show dependency tree
 
Reported: 2010-11-08 21:59 EST by Jeff McAffer CLA
Modified: 2014-04-02 12:03 EDT (History)
3 users (show)

See Also:


Attachments
patch (29.21 KB, patch)
2010-11-09 13:44 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (15.99 KB, application/octet-stream)
2010-11-09 13:44 EST, Kim Moir CLA
no flags Details
patch (7.57 KB, patch)
2010-11-09 14:28 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (3.29 KB, application/octet-stream)
2010-11-09 14:28 EST, Kim Moir CLA
no flags Details
patch (634 bytes, patch)
2010-11-09 14:58 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (8.14 KB, application/octet-stream)
2010-11-09 14:58 EST, Kim Moir CLA
no flags Details
patch to fix equinox build page generation (2.61 KB, patch)
2010-11-09 16:10 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (17.63 KB, application/octet-stream)
2010-11-09 16:10 EST, Kim Moir CLA
no flags Details
patch to include product feature in master equinox feature (652 bytes, patch)
2010-11-09 16:17 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (20.15 KB, application/octet-stream)
2010-11-09 16:17 EST, Kim Moir CLA
no flags Details
patch (2.00 KB, patch)
2010-11-09 18:21 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (6.26 KB, application/octet-stream)
2010-11-09 18:21 EST, Kim Moir CLA
no flags Details
patch (1.13 KB, patch)
2010-11-10 10:49 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (5.01 KB, application/octet-stream)
2010-11-10 10:49 EST, Kim Moir CLA
no flags Details
patch (2.14 KB, patch)
2010-11-10 10:49 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (5.01 KB, application/octet-stream)
2010-11-10 10:49 EST, Kim Moir CLA
no flags Details
patch (898 bytes, patch)
2010-11-10 10:50 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (5.01 KB, application/octet-stream)
2010-11-10 10:50 EST, Kim Moir CLA
no flags Details
patch to not specify feature version in product file (873 bytes, patch)
2010-11-10 16:02 EST, Kim Moir CLA
no flags Details | Diff
patch to reorganize run.xml (10.29 KB, patch)
2010-11-10 16:03 EST, Kim Moir CLA
no flags Details | Diff
zip names were incorrect on download page (2.26 KB, patch)
2010-11-12 15:05 EST, Kim Moir CLA
no flags Details | Diff
patch to branch executables (17.61 KB, patch)
2010-11-26 16:16 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (9.83 KB, application/octet-stream)
2010-11-26 16:16 EST, Kim Moir CLA
no flags Details
patch (11.97 KB, patch)
2010-12-01 14:36 EST, Kim Moir CLA
no flags Details | Diff
patch (2.60 KB, patch)
2010-12-01 14:36 EST, Kim Moir CLA
no flags Details | Diff
mylyn/context/zip (14.16 KB, application/octet-stream)
2010-12-01 14:36 EST, Kim Moir CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2010-11-08 21:59:34 EST
There are several new features and a new product that need to be built.  This is all just packaging of the existing bundles into useful groups and products.  I have updated the core.map file to have entries for the relevant features and the product definition is contained in a feature project.

feature@org.eclipse.equinox.core.feature - gathers together various low level Equinox bits (and Jobs)
feature@org.eclipse.equinox.p2.core.feature - groups the core p2 headless functionality
feature@org.eclipse.equinox.p2.extras.feature - adds toolish headless p2 function like director/publisher, ...
feature@org.eclipse.core.runtime.feature - combined with equinox core gives traditional Runtime function

feature@org.eclipse.equinox.starterkit.product.feature - combines equinox core and p2 core into a base runnable product.  This project contains a .product file.  

The features should all be included in the Equinox SDK.  The OSGi starter kit (the product) will be made available on the Eclipse RT website somewhere (not quite sure how yet).  

Topics.

- The product includes a copy of the windows console executables. We likely need to figure a better way of building that so the launchers are in sync with the rest of eclipse but yet mere mortals can build this product (or one of theirs that is just like this). I'm open to suggestions but the simplest thing for now was to just put copies in as root files for windows.  I did the right thing for Mac symbolic links.
Comment 1 Kim Moir CLA 2010-11-09 10:33:26 EST
Jeff, what platforms do you want the starter kit to run on?  I notice you have copied executables from for win32.win32.x86 and win32.win32.x86_64 but the product file specifies launcher arguments for the mac.
Comment 2 Jeff McAffer CLA 2010-11-09 10:42:05 EST
Its a great question.  Fortunately we are headless to the whole WS thing is out of the mix. Since the product is headless it is a console app and we need the console launcher.  That is only an issue on Windows thus the inclusion of eclipsec.exe 32/64-bit.  For the mac I did a p2.inf that adds a symlink so it can be run easily from the command line.

So, platforms.  I would think Win 32/64, linux 32/64 and Mac 32/64 should cover most of the bases.
Comment 3 Kim Moir CLA 2010-11-09 11:00:44 EST
So do you just want metadata generated for all the platforms in the repository so people can install this product from the repo?  Or do you want individual zips for all these platforms?
Comment 4 Jeff McAffer CLA 2010-11-09 11:33:34 EST
zip downloads.  This is a starter kit that people should be able to get, unzip and run.  Of course, the metadata should be in the repo to but we're really after the zips for the .product.
Comment 5 Kim Moir CLA 2010-11-09 13:29:45 EST
Jeff, what text do you want on the Equinox download page to describe the starter kit?
Comment 6 Jeff McAffer CLA 2010-11-09 13:41:11 EST
We should lkely have a new section as the second section on the download page.  Should read

OSGi Starter Kit
A useful collection of Equinox bundles packaged as a ready to run system.  This include the framework, p2 and other frequently used service implementations.

This section can be collapsed by default to save space since there will be 5-6 download entries.
Comment 7 Kim Moir CLA 2010-11-09 13:44:14 EST
Created attachment 182744 [details]
patch
Comment 8 Kim Moir CLA 2010-11-09 13:44:15 EST
Created attachment 182745 [details]
mylyn/context/zip
Comment 9 Jeff McAffer CLA 2010-11-09 14:00:21 EST
Thanks Kim. I noticed at the end of the patch the following
  equinox-OSGi-starterkit-@buildid@-win32.win32.x86..zip

Two things.  There are doubled '.' at the end.  and can we have the file called EclipseRT-OSGi-StarterKit-...
Comment 10 Kim Moir CLA 2010-11-09 14:28:21 EST
Created attachment 182755 [details]
patch
Comment 11 Kim Moir CLA 2010-11-09 14:28:23 EST
Created attachment 182756 [details]
mylyn/context/zip
Comment 12 Kim Moir CLA 2010-11-09 14:58:39 EST
Created attachment 182761 [details]
patch

extra space
Comment 13 Kim Moir CLA 2010-11-09 14:58:40 EST
Created attachment 182762 [details]
mylyn/context/zip
Comment 14 Kim Moir CLA 2010-11-09 16:10:18 EST
Created attachment 182772 [details]
patch to fix equinox build page generation
Comment 15 Kim Moir CLA 2010-11-09 16:10:22 EST
Created attachment 182773 [details]
mylyn/context/zip
Comment 16 Kim Moir CLA 2010-11-09 16:17:11 EST
Created attachment 182774 [details]
patch to include product feature in master equinox feature

since it's not included in other features
Comment 17 Kim Moir CLA 2010-11-09 16:17:12 EST
Created attachment 182775 [details]
mylyn/context/zip
Comment 18 Kim Moir CLA 2010-11-09 18:21:16 EST
Created attachment 182781 [details]
patch
Comment 19 Kim Moir CLA 2010-11-09 18:21:18 EST
Created attachment 182782 [details]
mylyn/context/zip
Comment 20 Kim Moir CLA 2010-11-10 10:49:28 EST
Created attachment 182823 [details]
patch
Comment 21 Kim Moir CLA 2010-11-10 10:49:29 EST
Created attachment 182824 [details]
mylyn/context/zip
Comment 22 Kim Moir CLA 2010-11-10 10:49:56 EST
Created attachment 182825 [details]
patch

sorry for all the patch spam :-)
Comment 23 Kim Moir CLA 2010-11-10 10:49:57 EST
Created attachment 182826 [details]
mylyn/context/zip
Comment 24 Kim Moir CLA 2010-11-10 10:50:20 EST
Created attachment 182827 [details]
patch
Comment 25 Kim Moir CLA 2010-11-10 10:50:21 EST
Created attachment 182828 [details]
mylyn/context/zip
Comment 26 Kim Moir CLA 2010-11-10 16:02:55 EST
Created attachment 182845 [details]
patch to not specify feature version in product file
Comment 27 Kim Moir CLA 2010-11-10 16:03:38 EST
Created attachment 182846 [details]
patch to reorganize run.xml
Comment 28 Kim Moir CLA 2010-11-10 18:41:55 EST
released for N20101110-2000.  The test build is here if you want to look at the zips.

https://hudson.eclipse.org/hudson/view/Eclipse%20and%20Equinox/job/eclipse-equinox-test-N/208/artifact/builds/transfer/files/bogus/equinox/drops/N20101110-1554/
Comment 29 Jeff McAffer CLA 2010-11-12 11:29:24 EST
I sniffed around the starter kit and it looks good with one set of issues around the root files/executables.

It seems like there is some extra build magic happening to get a set of executables and root files rather than following what is defined in the .product file.  In the starter kit .product we setup the executable to be called rt but that's not what is happening on the various platforms.

On the mac the executable is Eclipse.app. It should be rt.app and the eclipse symlink should be named rt.  There is a p2.inf that creates the rt symlink but the link is broken because the app is not rt.app.

On windows ideally the only executable would be rt.exe and this would actually be a copy of eclipsec.exe.  For now we have manually copied eclipsec.exe, named it rtc.exe and contribute it via root files.  It seems like this is not coming through.

On linux the executable is called eclipse (should be rt) and there is an swt cairo lib in the root.  The icon.xpm is the Eclipse one as opposed to the EclipseRT one but we did not contribute something there.  Not really sure there should be one...
Comment 30 Jeff McAffer CLA 2010-11-12 11:32:54 EST
I committed too soon...

There is a topic around how to get the latest launchers on windows and have them named/branded as described in the .product.  Perhaps we can write some p2.inf actions that will do the work (eg. delete eclipse.exe and rename eclipsec.exe?)  On the other platforms we should be good with the info in the .product and p2.inf.
Comment 31 Jeff McAffer CLA 2010-11-12 11:41:18 EST
sigh...  Also forgot to mentino that the linux build has several about entries in the root that should not be there. 

On reflection, it looks like the executables feature is being included and bring along things.  This is a separate issue from the releng topic for now.    I'll open a separate bug in launcher or pde build to work on that.

Notwithstanding, having rt.exe etc be there would be good.  We should still be able to do the branding as normal.
Comment 32 Jeff McAffer CLA 2010-11-12 11:51:18 EST
See Bug 330113 for a discussion of the executables feature issues
Comment 33 Jeff McAffer CLA 2010-11-12 14:53:57 EST
For completeness, there are five new features.  I have added them to the maps file and tagged them with the current content.  Going forward they will need to be tagged in the normal process.  The five features are:

feature@org.eclipse.equinox.core.feature
feature@org.eclipse.equinox.p2.core.feature
feature@org.eclipse.equinox.p2.extras.feature
feature@org.eclipse.core.runtime.feature
feature@org.eclipse.equinox.starterkit.product.feature
Comment 34 Kim Moir CLA 2010-11-12 15:05:10 EST
Created attachment 183035 [details]
zip names were incorrect on download page
Comment 35 Jeff McAffer CLA 2010-11-15 08:04:13 EST
I get 404s for the starter kits on 
    http://download.eclipse.org/equinox/drops/N20101114-2000/index.php
Comment 36 Kim Moir CLA 2010-11-15 09:36:23 EST
Regarding comment #35, yes I released a fix for this on Friday but didn't tag the builder because I was testing other bugs.  I've released this fix for tonight's build.
Comment 37 Kim Moir CLA 2010-11-16 10:36:11 EST
I talked to Andrew regarding how to rename the executables and generate the appropriate metadata
Here is the result of our conversation.

<eclipse.brand.p2.artifacts>
10:06:04 AM: Andrew Niefer:  <eclipse.brand.p2.artifacts  launcherName="${launcherName}" config="linux.gtk.x86" iconsList="${launcherIcons}" launcherProvider="${launcherProvider}" productId="org.eclipse.webide" productVersion="0.0.2.${p2.product.qualifier}" repository="${p2.build.repo}" tempDirectory="${assemblyTempDir}"           />

10:08:25 AM: Andrew Niefer: launcerProvider=org.eclipse.equinox.executable
10:25:00 AM: Andrew Niefer: buildConfiguration.xml/
10:25:27 AM: Andrew Niefer: 		<path id="launcher.paths">
			<fileset dir="${reposource}" includes="plugins/org.eclipse.equinox.launcher*" />
			<!-- the built version of the org.eclipse.equinox.executable feature -->
			<dirset dir="${buildDirectory}" includes="features/org.eclipse.equinox.executable*" />    <-- replace with built version
		</path>
Comment 38 Kim Moir CLA 2010-11-26 16:16:05 EST
Created attachment 183960 [details]
patch to branch executables
Comment 39 Kim Moir CLA 2010-11-26 16:16:08 EST
Created attachment 183961 [details]
mylyn/context/zip
Comment 40 Kim Moir CLA 2010-12-01 14:36:06 EST
Created attachment 184292 [details]
patch
Comment 41 Kim Moir CLA 2010-12-01 14:36:44 EST
Created attachment 184293 [details]
patch
Comment 42 Kim Moir CLA 2010-12-01 14:36:46 EST
Created attachment 184294 [details]
mylyn/context/zip
Comment 43 Kim Moir CLA 2010-12-01 14:39:34 EST
The branding is fixed for N20101201-2000.  I started one up and it just starts the osgi console, I guess this is expected :-)