Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329707 - JUnits testing providers for non existing project are incorrect
Summary: JUnits testing providers for non existing project are incorrect
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 15:58 EST by Roberto Sanchez Herrera CLA
Modified: 2011-01-10 10:59 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Check for null instead of IllegalArgumentException. (2.70 KB, patch)
2010-11-08 16:01 EST, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2010-11-08 15:58:56 EST 
Build Identifier: I-3.3.0-20101021033924

The JUnits org.eclipse.jst.jee.model.ejb.tests.testProviderForNonExistingProject() and org.eclipse.jst.jee.model.web.tests.testProviderForNonExistingProject() check fot an IllegalArgumentException when ModelProviderManager.getModelProvider(IProject) is called on non-existing project. But the method is returning null. In fact, the API says it expects a null back. 

Reproducible: Always

Steps to Reproduce:
1. Run the AllAnnotationModelModelTests suite.
Comment 1 Roberto Sanchez Herrera CLA 2010-11-08 16:01:08 EST 
Created attachment 182664 [details]
Check for null instead of IllegalArgumentException.
Comment 2 Chuck Bridgham CLA 2010-11-10 10:14:23 EST 
approve
Comment 3 Jason Sholl CLA 2010-11-10 12:31:34 EST 
Code checked into both 32M and HEAD for WTP 3.2.3 and 3.3