Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329697 - reevaluate logout "hack"
Summary: reevaluate logout "hack"
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 359210
  Show dependency tree
 
Reported: 2010-11-08 13:31 EST by Thomas Ehrnhoefer CLA
Modified: 2011-09-28 07:51 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2010-11-08 13:31:55 EST
I was looking into some bugzilla query performance on one of our instances, and started to debug the performQuery. Just for the record, here is the (I think) intended workflow of Bugzilla's performQuery:

	1. getSearchHits
	2. if no hits
		1. logout
		2. getSearchHits

Problem is that in my case, every performQuery will have no hits for the first getSearchHits try, and thus do logout and try again.
Of the query tested, a successful getSearchHits, taskes about 2.5sec, but the unsuccessful one plus the logout add additional 2-3sec to that. The whole peformQuery thus takes about twice as long as is should I think.

Not why does it always fail on the first try? Well, if a query has not changed tasks, the getSearchHits has no hits. So the logout and retry will be useless in a whole lot of calls. It seems this retry was added due to IP changes ("// XXX: HACK in case of ip change bugzilla can return 0 hits"), but it seems like a problematic hack (well, are there non-problematic ones...) as it slows down every user on probably the majority of calls.
Comment 1 Steffen Pingel CLA 2010-11-08 14:35:54 EST
Agreed. There should be a better way to verify if a user is logged in or not.
Comment 2 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn