Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329696 - CDO downloads page calls the webserver, loops and consumes many resources
Summary: CDO downloads page calls the webserver, loops and consumes many resources
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.docs (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 13:13 EST by Denis Roy CLA
Modified: 2011-06-23 04:23 EDT (History)
1 user (show)

See Also:

Attachments
Access log (15.12 KB, text/plain)
2010-11-08 13:13 EST, Denis Roy CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Roy CLA 2010-11-08 13:13:18 EST 
Created attachment 182643 [details]
Access log

On www.eclipse.org, I am seeing frequent exhaustion of available sockets for http clients.  It appears there is something broken with the CDO downloads page.  Since this page calls the webserver itself (instead of opening files locally), each nested call occupies one client 'slot' until all 800 are consumed and never released.

Please:

a) avoid opening "local" URLs such as www.eclipse.org -- this consumes 2x the memory for one page hit

b) test for endless loops in your PHP code


Attached is a very small subset of my Apache log.  The IP address you see is the webserver calling itself.  I'm seeing hits in excess of 30/second.
Comment 1 Denis Roy CLA 2010-11-08 14:42:10 EST 
http://www.eclipse.org/cdo/downloads/ seems to be the culprit.  I've commented out this line, since it seems to be the culprit:

# printDownloads("http://www.eclipse.org/modeling/emf/downloads/index.php?project=cdo&showAll=0&showMax=5");
Comment 2 Denis Roy CLA 2010-11-08 14:43:22 EST 
Actually, http://www.eclipse.org/modeling/emf/downloads/index.php?project=cdo&showAll=0&showMax=5 seems to redirect to /downloads/cdo/, which is a big part of the problem.
Comment 3 Eike Stepper CLA 2010-11-09 00:32:30 EST 
Investigating...
Comment 4 Eike Stepper CLA 2010-11-09 00:39:45 EST 
I've found the loop and removed it. Sorry for the hazzle!
Comment 5 Eike Stepper CLA 2010-11-09 00:45:58 EST 
Denis, am I right that you've entirely "blanked" the URL http://www.eclipse.org/cdo/downloads/ ? I can not test whether my changes aolve the issue but I'm 100% sure that they do. Please remove your extra filter and try it...
Comment 6 Denis Roy CLA 2010-11-09 09:57:46 EST 
I've removed my code and updated from CVS. Looks like it works now, thanks.
Comment 7 Eike Stepper CLA 2011-06-23 04:23:06 EDT 
Closing.