Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329693 - Using EJBJAR/WEBAPP discoverer from popup menu on not conform file leads to "invalid thread access"
Summary: Using EJBJAR/WEBAPP discoverer from popup menu on not conform file leads to "...
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 0.9.0 M4   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 12:31 EST by Fabien Giquel CLA
Modified: 2011-01-11 05:18 EST (History)
2 users (show)

See Also:
fabien.giquel: indigo+

Attachments
Patch for Invalid Thread access in JEE discoverers. (3.75 KB, patch)
2010-11-15 10:05 EST, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabien Giquel CLA 2010-11-08 12:31:55 EST 
For instance on plugin.xml file, use one of the following discoverer :
- Discover JEE Web Deployment descriptor
- Discover JEE Ejb Deployment descriptor

It leads to an abnormal "invalid thread access" when trying to indicate to the user that the file is not conform.

This issue affect also incubating "struts" and "hibernate" discoverers.
Comment 1 Nicolas Guyomar CLA 2010-11-15 10:05:27 EST 
Created attachment 183123 [details]
Patch for Invalid Thread access in JEE discoverers.

Hi,

This bug was due to a wrong use of a popup instead of using MoDisco Logger to handle errors.

Here is a patch which raises a warning when the file's version is not determined by the discoverer

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL


Regards

Nicolas Guyomar
Comment 2 Fabien Giquel CLA 2010-11-16 03:30:52 EST 
Thks Nicolas,

Here is a contribution from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

The contribution has been commited into SVN (revision 3612 3613).
Comment 3 Hugo Bruneliere CLA 2011-01-11 05:18:22 EST 
Bug fixed via a patch.