Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329673 - NPE in Branch Selection dialog
Summary: NPE in Branch Selection dialog
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.10.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jens Baumgart CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 08:53 EST by Jens Baumgart CLA
Modified: 2010-11-09 18:20 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Baumgart CLA 2010-11-08 08:53:54 EST 
NPE happens when selecting a branch name using the arrow keys and pressing return.
By moving the arrow key the node does not get selected.

java.lang.NullPointerException
at org.eclipse.egit.ui.internal.dialogs.AbstractBranchSelectionDialog$2.open(AbstractBranchSelectionDialog.java:166)
at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:845)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:843)
at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1131)
at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1235)
at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:264)
at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:258)
at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:298)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
Comment 1 Jens Baumgart CLA 2010-11-08 09:17:37 EST 
- search a branch that was not selected before
- press tab
- now the branch has the focus, but no selection
- press enter => NPE
Comment 2 Jens Baumgart CLA 2010-11-08 12:06:25 EST 
Fix proposed: http://egit.eclipse.org/r/#change,1866
Comment 3 Matthias Sohn CLA 2010-11-09 18:20:52 EST 
merged as 91a8f3bfc8c25b4a975ceed8e5ab87077fb59121