Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329632 - Create common access mechanism for SharedIcons
Summary: Create common access mechanism for SharedIcons
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.ui (show other bugs)
Version: 4.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Martin Fluegge CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard: Lighter, Faster and Better
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-07 12:02 EST by Martin Fluegge CLA
Modified: 2011-06-23 03:39 EDT (History)
0 users

See Also:
stepper: review+

Attachments
new Projects (140.23 KB, application/octet-stream)
2010-11-07 12:09 EST, Martin Fluegge CLA 		no flags Details
Patch v1 (107.96 KB, patch)
2010-11-07 12:11 EST, Martin Fluegge CLA 		no flags Details | Diff
mylyn/context/zip (952 bytes, application/octet-stream)
2010-11-07 12:11 EST, Martin Fluegge CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fluegge CLA 2010-11-07 12:02:50 EST 
All SharedIcons class and all icons should be accessible from a common source to avoid duplication of classes and icons.
Comment 1 Martin Fluegge CLA 2010-11-07 12:09:40 EST 
Created attachment 182574 [details]
new Projects

I moved the icons and the SharedIcon class to a separated plugin. Now all icons can be accessed directly after including the new bundle. I did it likewise for Net4J. The changes for the existing bundles will be attached in the next patch.
Comment 2 Martin Fluegge CLA 2010-11-07 12:11:32 EST 
Created attachment 182575 [details]
Patch v1

Here are the changes for the existing plugins. Unfortunately the binary changes (deletion/move of icons) are note included.

Eike, it would be best if you ping to review the changes in a remote session.
Comment 3 Martin Fluegge CLA 2010-11-07 12:11:35 EST 
Created attachment 182576 [details]
mylyn/context/zip
Comment 4 Martin Fluegge CLA 2010-11-13 11:35:03 EST 
As discussed I checked the new projects in and committed the changes. I also added the new projects to the appropriate features. Please import the new projects using Buckminster.

Patch v1 committed to HEAD.
Comment 5 Eike Stepper CLA 2010-11-18 01:26:20 EST 
Resolving FIXED
Comment 6 Eike Stepper CLA 2011-06-23 03:39:33 EDT 
Available in R20110608-1407