Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329581 - [Compatibility] View perspectiveExtensions to placeholder folders do not show up
Summary: [Compatibility] View perspectiveExtensions to placeholder folders do not show up
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 14:43 EDT by Remy Suen CLA
Modified: 2010-11-06 04:53 EDT (History)
1 user (show)

See Also:

Attachments
ModeledPageLayout patch v1 (1020 bytes, patch)
2010-11-05 14:49 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-05 14:43:55 EDT 
The view is correctly added to the folder but it is not visible on startup.

Perspective factory code:
public void createInitialLayout(IPageLayout factory) {
  factory.createPlaceholderFolder(
      "leftFolder", IPageLayout.LEFT, 0.25f, //$NON-NLS-1$
      factory.getEditorArea());
}

View extension:

<view id="org.eclipse.ui.views.ResourceNavigator"
    relationship="stack"
    relative="leftFolder"
    visible="true">
</view>
Comment 1 Remy Suen CLA 2010-11-05 14:49:12 EDT 
Created attachment 182512 [details]
ModeledPageLayout patch v1

The view was being contributed correctly to the placeholder folder but the stack itself was not being rendered (since it was a placeholder folder). The fix is to ask it to be rendered if a visible view has been contributed to it.
Comment 2 Remy Suen CLA 2010-11-05 14:51:26 EDT 
(In reply to comment #1)
> Created an attachment (id=182512) [details]
> ModeledPageLayout patch v1

Fix released to CVS HEAD.

Thanks for the bug report, Thomas! Please let us know if you encounter other problems with the 4.x SDK.
Comment 3 Remy Suen CLA 2010-11-05 14:51:32 EDT 
Whoops.
Comment 4 Thomas Kratz CLA 2010-11-06 04:53:36 EDT 
Thanks for fixing this so quickly. I'll try the patches right now.