Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329549 - Change PartState.VISIBLE to be like PartState.ACTIVE if the requested part is in the same stack as the currently active part
Summary: Change PartState.VISIBLE to be like PartState.ACTIVE if the requested part is...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 396853
  Show dependency tree
 
Reported: 2010-11-05 09:53 EDT by Remy Suen CLA
Modified: 2014-10-13 10:23 EDT (History)
2 users (show)

See Also:

Attachments
EPartService patch v1 (6.65 KB, patch)
2010-11-05 10:01 EDT, Remy Suen CLA 		no flags Details | Diff
EPartService patch v2 (11.78 KB, patch)
2010-11-05 11:12 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-05 09:53:32 EDT 
At the moment, if you call the showPart(*) APIs with a PartState.VISIBLE argument, the part may not actually become visible if it is in the same stack as the currently active part. This mirrors the API in 3.x but is essentially counterintuitive as the resulting user interface does not match what the words seem to imply, that being that the part is actually obscured by the active part instead of being "visible".
Comment 1 Remy Suen CLA 2010-11-05 10:01:26 EDT 
Created attachment 182472 [details]
EPartService patch v1
Comment 2 Remy Suen CLA 2010-11-05 10:25:35 EDT 
(In reply to comment #1)
> Created an attachment (id=182472) [details]
> EPartService patch v1

This patch does not include the necessary changes to the 4.x workbench implementation. The code as-is will mean the IWorkbenchPage.VIEW_VISIBLE argument will not be honoured correctly if the shown part is in the same stack as the active part.
Comment 3 Remy Suen CLA 2010-11-05 11:12:48 EDT 
Created attachment 182482 [details]
EPartService patch v2

This patch incorporates additional changes to preserve the behaviour of the 3.x APIs.
Comment 4 Remy Suen CLA 2010-11-05 11:13:18 EDT 
Fixed in CVS HEAD.
Comment 5 Eric Moffatt CLA 2010-11-05 15:46:05 EDT 
Nice !

Should we consider fixing this for 3.x ?
Comment 6 Remy Suen CLA 2010-11-05 16:02:34 EDT 
(In reply to comment #5)
> Should we consider fixing this for 3.x ?

I think not, because then you would be changing/breaking the API. ;)
Comment 7 Dani Megert CLA 2014-10-13 10:22:04 EDT 
This change was wrong and makes it impossible to make a part visible without forcing focus on it.
Comment 8 Dani Megert CLA 2014-10-13 10:23:39 EDT 
Let's keep this one closed and deal with it via the regression bug 396853.