Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329525 - The org.apache.bsf bundle does not export needed packages.
Summary: The org.apache.bsf bundle does not export needed packages.
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: Indigo M6   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 06:35 EDT by Thomas Hallgren CLA
Modified: 2011-03-02 21:36 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2010-11-05 06:35:17 EDT 
The Orbit org.apache.bsf bundle does not export several needed packages. In particular, it's impossible to extend the org.apache.bsf.util.BSFEngineImpl class. The javadoc for that class reads:

 * This is a base implementation of the BSFEngine interface which
 * engine implementations may choose to extend to get the basic 
 * methods of the interface implemented. 

The current bundle is very restrictive and only exports the top level package org.apache.bsf so extending the BSFEngineImpl is impossible.

I would suggest exporting all packages unless there is a good reason not to.
Comment 1 David Williams CLA 2010-11-05 09:51:39 EDT 
Sounds reasonable. 

At times, we do purposely not export "internal" classes which are explicitly not intended to be used by clients, but this does not sound like one of those case, judging from the quoted javadoc. 

Michael, I've assigned to you since you are listed as the contact for this bug, but please assign back to me if you can not get to this in the next few weeks, so we can release this fix for M4. Unless you disagree with the change, of course. 

Thanks.
Comment 2 David Williams CLA 2011-02-08 00:26:03 EST 
Mike ... was this ever fixed and just not marked?  Do you still "own" it?
Comment 3 David Williams CLA 2011-03-02 21:36:53 EST 
Mike? Mike? ... guess Mike's out. 

I've fixed by exporting all the packages. 

Thanks for reporting.