Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329486 - UIEventsTest's testAllTopics() fails with code from HEAD
Summary: UIEventsTest's testAllTopics() fails with code from HEAD
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-04 16:09 EDT by Remy Suen CLA
Modified: 2010-12-07 14:48 EST (History)
2 users (show)

See Also:

Attachments
Patch (98.35 KB, patch)
2010-11-12 10:54 EST, Oleg Besedin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-04 16:09:26 EDT 
Anyone else getting this? I'm seeing this with the code from HEAD.

junit.framework.AssertionFailedError: No event fired:[Ljava.lang.String;@417348 dirty
	at junit.framework.Assert.fail(Assert.java:47)
	at org.eclipse.e4.ui.tests.application.UIEventsTest.ensureAllSet(UIEventsTest.java:373)
	at org.eclipse.e4.ui.tests.application.UIEventsTest.checkForFailures(UIEventsTest.java:336)
	at org.eclipse.e4.ui.tests.application.UIEventsTest.testAllTopics(UIEventsTest.java:290)
Comment 1 Paul Webster CLA 2010-11-05 09:16:54 EDT 
Related to schema changes for bug 306576

PW
Comment 2 Oleg Besedin CLA 2010-11-12 10:54:17 EST 
Why do we need a separate model for testing?
Comment 3 Oleg Besedin CLA 2010-11-12 10:54:57 EST 
Created attachment 183005 [details]
Patch

Regenerated org.eclipse.e4.ui.tests\model\TestModel.genmodel .
Comment 4 Oleg Besedin CLA 2010-11-12 10:58:24 EST 
Patch applied to CVS Head to fix failing JUnit. 

The following files were modified: \
  MTestPackage
  TestHarnessImpl
if this cange causes problems please feel free to rollback.
Comment 5 Thomas Schindl CLA 2010-11-12 10:59:19 EST 
(In reply to comment #2)
> Why do we need a separate model for testing?

Where else would you put the test element found in there?
Comment 6 Eric Moffatt CLA 2010-12-07 14:48:32 EST 
Verified in I20101207-0250.