Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329432 - Commons Httpclient is missing the Apache NOTICE file
Summary: Commons Httpclient is missing the Apache NOTICE file
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: Indigo M5   Edit
Assignee: Martin Oberhuber CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 327661
  Show dependency tree
 
Reported: 2010-11-04 09:06 EDT by Martin Oberhuber CLA
Modified: 2010-12-07 04:30 EST (History)
0 users

See Also:

Attachments
Patch fixing the issue (2.44 KB, patch)
2010-12-07 02:53 EST, Martin Oberhuber CLA 		no flags Details | Diff
Updated patch, fixing XHTML validation in about.html (5.12 KB, patch)
2010-12-07 04:02 EST, Martin Oberhuber CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-11-04 09:06:43 EDT 
The commons httpclient binary bundle is missing the Apache NOTICE file (or NOTICE.txt). This is severe, because without that NOTICE file the redistribution violates clause 4d of the Apache 2.0 license.

I checked the original HTTPClient sources and they do contain a NOTICE file:
http://www.gtlib.gatech.edu/pub/apache//httpcomponents/commons-httpclient/source/commons-httpclient-3.1-src.zip

The Eclipse / Orbit distro however does not, and the respective hyperlink in about.html is broken. Also, the copyright-to-year is incorrect (2005 according to Eclipse about.html but 2007 according to the Apache NOTICE file).

org.apache.commons.httpclient_3.1.0.v201005080502.jar : about.html
  caution: filename not matched:  about_files/NOTICE.txt
Comment 1 Martin Oberhuber CLA 2010-12-07 02:53:16 EST 
Created attachment 184685 [details]
Patch fixing the issue

Attached patch fixes the issue.
Comment 2 Martin Oberhuber CLA 2010-12-07 04:02:38 EST 
Created attachment 184691 [details]
Updated patch, fixing XHTML validation in about.html
Comment 3 Martin Oberhuber CLA 2010-12-07 04:30:20 EST 
Released the Fix >= I20101207 (Indigo M5).