Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329397 - [index] Need way to wait for JSP index to be consistent
Summary: [index] Need way to wait for JSP index to be consistent
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 333903
  Show dependency tree
 
Reported: 2010-11-03 16:47 EDT by Ian Tewksbury CLA
Modified: 2011-01-12 23:49 EST (History)
4 users (show)

See Also:
thatnitind: review+
nsand.dev: review+

Attachments
New Indexer Patch (149.57 KB, patch)
2010-11-03 16:48 EDT, Ian Tewksbury CLA 		thatnitind: iplog+
Details | Diff
Fix Patch - Update 1 (147.39 KB, patch)
2011-01-10 16:07 EST, Ian Tewksbury CLA 		no flags Details | Diff
Fix Patch - Update 3 (149.58 KB, patch)
2011-01-10 16:11 EST, Ian Tewksbury CLA 		nsand.dev: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2010-11-03 16:47:36 EDT 
The patch for this is slightly different then in 3.2.3.  This one includes new strings for more verbose progress reporting.

+++ This bug was initially created as a clone of Bug #323079 +++
We need a way to wait for the JSP index to be consistent before performing operations like searches.

Long story short, the best way to go about doing this was to re-in-vision the JSP indexer.  I took it a step further and wrote a generic Index manager that could manage tracking any type of file in the workspace and then wrote an implementation of it designed to track JSP pages.  This JSP tracker takes care of injecting JSPs into the JDT index and also calling the API to persist the translations.

The framework for this generic index manager was very much based of how the JSPTranslatorPersister worked.  Part of my changes were to rip out all the code the JSPTranslatorPersister used to track JSP changes and to just have the new JSPIndexManager use the JSPTranslatorPersister to persist the translations for the JSP files it finds.

I have only done some basic testing on this new indexer including running all the Junits.  Still needs much testing but its about time someone else take a gander at the code.
Comment 1 Ian Tewksbury CLA 2010-11-03 16:48:42 EDT 
Created attachment 182329 [details]
New Indexer Patch

Patch.  Essentially the same patch that is attached to Bug 323079 except it includes new strings for more verbose progress reporting.
Comment 2 Ian Tewksbury CLA 2011-01-10 16:07:16 EST 
Created attachment 186429 [details]
Fix Patch - Update 1

Updated the patch to apply cleaning to current HEAD as well as updated with the final changes that went into the 3.2.3 patch before it was omitted.
Comment 3 Ian Tewksbury CLA 2011-01-10 16:11:56 EST 
Created attachment 186430 [details]
Fix Patch - Update 3

There was an issue with my last merge in that I lost some of the new strings from 3.3.  This one is good to go, I swear.
Comment 4 Nick Sandonato CLA 2011-01-10 17:49:34 EST 
Thanks for your patch, Ian. Code has been released.