Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329382 - [releng] 4.1 needs fixed Orbit builds
Summary: [releng] 4.1 needs fixed Orbit builds
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 358542 (view as bug list)
Depends on: 329376
Blocks:
  Show dependency tree
 
Reported: 2010-11-03 14:05 EDT by Paul Webster CLA
Modified: 2011-09-22 06:17 EDT (History)
8 users (show)

See Also:


Attachments
Patch for the Batik v1.7 bundles with the issue. (13.83 KB, text/plain)
2010-11-04 14:53 EDT, Anthony Hunter CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-11-03 14:05:54 EDT
The newer version of OSGi throws out bundles with bad attributes.  org.apache.batik.css 1.6.0.v200912221622 currently says org.apache.batik.util;version="[1.6.0,1.7.0)" instead of org.apache.batik.util;bundle-version="[1.6.0,1.7.0)"

org.apache.batik.util has it was well (in the  1.7.0.v200903091627 version, probably in 1.6.0.x as well).

We need to pick up bundles from Orbit with fixed attributes for this week's e4/4.1 build.

PW
Comment 1 Paul Webster CLA 2010-11-03 14:28:03 EDT
Andrew, as an aside we include both the 1.6 and 1.7 versions of the batik libraries (they're not singletons).

Our plugin specifies org.apache.batik.css;bundle-version="[1.6.0,1.7.0)", so I'm not sure why we're pulling in the 1.7 versions of batik.util 

PW
Comment 2 Andrew Niefer CLA 2010-11-04 11:41:02 EDT
Our bundle (org.eclipse.e4.ui.css.core) gets resolved to batik.css_1.6.0.  It is the dependency from batik.css that pulls in the other util bundles, and the version attributes there were meaningless so the resolver is free to resolve against whatever version it likes, and in general higher versions get selected.
Comment 3 Andrew Niefer CLA 2010-11-04 11:44:39 EDT
Also, I notice our map files actually list both 1.6 and 1.7 versions of the batik.util bundles.  As well as multiple versions of some other orbit bundles.  PDE/Build will fetch the highest version in the map file unless the feature specifies otherwise.
Comment 4 Brian de Alwis CLA 2010-11-04 13:49:44 EDT
org.w3c.dom.svg has the same issue:

[...MANIFEST.MF...]
Bundle-SymbolicName: org.w3c.dom.svg
Require-Bundle: org.w3c.dom.smil;version="[1.0.0,1.1.0)"
Export-Package: org.w3c.dom.svg;version="1.1.0"
[...]
Comment 5 Brian de Alwis CLA 2010-11-04 13:57:45 EDT
Just to certain, I scanned through all the bundles that I have available for 'Require-Bundle.*;version=' and found 4:

==> org.apache.batik.css_1.6.0.v200912221622.jar
Require-Bundle: org.apache.batik.util;version="[1.6.0,1.7.0)",org.w3c.css.sac;version="[1.3.0,1.4.0)",org.w3c.dom.svg;version="[1.1.0,1.3.0)"
==> org.apache.batik.util_1.6.0.v200805290154.jar
Require-Bundle: org.apache.batik.util.gui;version="[1.6.0,1.7.0)"
==> org.apache.batik.xml_1.6.0.v200805290154.jar
Require-Bundle: org.apache.batik.util;version="[1.6.0,1.7.0)"
==> org.w3c.dom.svg_1.1.0.v200806040011.jar
Require-Bundle: org.w3c.dom.smil;version="[1.0.0,1.1.0)"
Comment 6 Thomas Watson CLA 2010-11-04 14:36:39 EDT
Please use bug329376 to report any additional orbit bundles that need fixing.

(In reply to comment #4)
> org.w3c.dom.svg has the same issue:
> 
> [...MANIFEST.MF...]
> Bundle-SymbolicName: org.w3c.dom.svg
> Require-Bundle: org.w3c.dom.smil;version="[1.0.0,1.1.0)"
> Export-Package: org.w3c.dom.svg;version="1.1.0"

Please note that "version" attribute on Export-Package and Import-Package is valid.  We are only interested in Require-Bundle cases here.

> [...]
Comment 7 Anthony Hunter CLA 2010-11-04 14:53:50 EDT
Created attachment 182413 [details]
Patch for the Batik v1.7 bundles with the issue.

Committed the fixes for the Batik v1.7 bundles with the issue and released as v201011041433.
Comment 8 Anthony Hunter CLA 2010-11-04 14:55:50 EDT
(In reply to comment #7)
> Created an attachment (id=182413) [details]
> Patch for the Batik v1.7 bundles with the issue.
> 
> Committed the fixes for the Batik v1.7 bundles with the issue and released as
> v201011041433.

I guess this should have gone in Bug 329376.
Comment 9 Andrew Niefer CLA 2010-11-04 18:14:30 EDT
I have updated the map files to use
http://download.eclipse.org/tools/orbit/downloads/drops/I20101104194033/ for
org.apache.batik.css
org.apache.batik.util
org.apache.batik.util.gui
org.wsc.dom.svg

Any other orbit bundles remain with their old map entries
Comment 10 David Williams CLA 2011-09-22 06:17:46 EDT
*** Bug 358542 has been marked as a duplicate of this bug. ***