Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329361 - Ensure manifest bundle requires use proper attr key for version
Summary: Ensure manifest bundle requires use proper attr key for version
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-03 11:07 EDT by DJ Houghton CLA
Modified: 2010-11-10 09:56 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-11-03 11:07:36 EDT 
The p2 tests didn't run in the latest builds. Upon further examination by Tom, there is an invalid header in the manifest file in the Require-Bundle section:
    org.eclipse.equinox.simpleconfigurator.manipulator;version="[2.0.0,3.0.0)",

If you have a Require-Bundle you need to use "bundle-version" and if you have a package import, then you can just use "version".

I'll change the one in the p2.tests bundle and look at the rest of the p2 bundles to see if we have any others which are wrong.
Comment 1 DJ Houghton CLA 2010-11-03 11:13:51 EDT 
Tom mentioned that this error shows up now due to changes in bug 328508.
Comment 2 DJ Houghton CLA 2010-11-03 11:25:07 EDT 
I've confirmed that the p2.tests bundle was the only one with the malformed manifest. I've released the fix to HEAD.
Comment 3 Pascal Rapicault CLA 2010-11-09 22:55:30 EST 
Out of curiosity, why was this working in the past and no longer works now? Did the fwk become more picky?
Comment 4 Paul Webster CLA 2010-11-10 07:54:13 EST 
(In reply to comment #3)
> Out of curiosity, why was this working in the past and no longer works now? Did
> the fwk become more picky?

Require bundle now supports arbitrary matching attributes.  version is now being evaluated and of course there's no match.
Comment 5 Thomas Watson CLA 2010-11-10 08:51:12 EST 
(In reply to comment #3)
> Out of curiosity, why was this working in the past and no longer works now? Did
> the fwk become more picky?

Pascal, this is the issue we discussed on the Monday Equinox call and I posted to the cross-project mailing list.  As Paul points out arbitrary matching attributes now have meaning and are processed by the framework for Require-Bundle and Fragment-Host.
Comment 6 Pascal Rapicault CLA 2010-11-10 09:17:38 EST 
Could not that break external adopters?
Comment 7 Thomas Watson CLA 2010-11-10 09:56:25 EST 
(In reply to comment #6)
> Could not that break external adopters?

This discussion is happening in bug329375.  Please add your concerns to that bug.