Community
Participate
Working Groups
We were trying to build a patched version of the org.eclipse.jst.jsp.core plugin for Helios SR1 in an adopter product and hit a failure in the build process. The TaglibHelper class in org.eclipse.jst.jsp.core creates a new TagLibraryInfo, extending the abstract class javax.servlet.jsp.tagext.TagLibraryInfo. The implementation in TaglibHelper is just an empty/dummy implementation - which is fine with version 2.0.0 of javax.servlet.jsp jar. However in a build environment that also includes a 2.1.0 version of the javax.servlet.jsp jar, you get an error requiring the implementation of the inherited abstract method getTagLibraryInfos(). The fix is to change the manifest so that the import declaration uses a closed range (exclusive of 2.1) Import-Package: javax.servlet.jsp.tagext;version="[2.0.0,2.1.0)" rather than version="2.0.0"
Created attachment 182250 [details] change import declaration to use a closed range
Or ... I wonder if TaglibHelper should just implement the missing method. I'm assuming it could be a "dummy" implementation, that always returned null or something? Since, I'm assuming this is a "placeholder" for whatever "real" helper is used later? I don't think having the "extra" method would hurt when running on 2.0?
(In reply to comment #2) > Or ... I wonder if TaglibHelper should just implement the missing method. > > I'm assuming it could be a "dummy" implementation, that always returned null or > something? Since, I'm assuming this is a "placeholder" for whatever "real" > helper is used later? > > I don't think having the "extra" method would hurt when running on 2.0? Nitin and I have discussed implementing the methods and also widening the range to [2.0.0, 2.2.0]
(In reply to comment #3) > (In reply to comment #2) > > Or ... I wonder if TaglibHelper should just implement the missing method. > > > > I'm assuming it could be a "dummy" implementation, that always returned null or > > something? Since, I'm assuming this is a "placeholder" for whatever "real" > > helper is used later? > > > > I don't think having the "extra" method would hurt when running on 2.0? > > Nitin and I have discussed implementing the methods and also widening the range > to [2.0.0, 2.2.0] Doh, [2.0.0, 2.2.0)
Created attachment 184748 [details] patch
Stripped out some of the unnecessary changes from another patch.
Created attachment 184758 [details] updated patch
