Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329253 - OpenBreakpointMarkerAction calls "internal" setFocus() method on IWorkbenchParts
Summary: OpenBreakpointMarkerAction calls "internal" setFocus() method on IWorkbenchParts
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 09:16 EDT by Remy Suen CLA
Modified: 2011-05-06 17:34 EDT (History)
3 users (show)

See Also:
pawel.1.piech: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-02 09:16:43 EDT 
setFocus() is called in line 79 of OpenBreakpointMarkerAction. This is not a method that clients should be calling (as spec'd in the javadoc).
Comment 1 Darin Wright CLA 2010-11-02 10:13:02 EDT 
Looks like we should use the IWorkbenchPage.openEditor(...) API that accepts an "activate" boolean parameter instead.
Comment 2 Darin Wright CLA 2010-11-02 11:02:58 EDT 
Fixed in HEAD.
Comment 3 Pawel Piech CLA 2011-05-06 17:34:59 EDT 
Reviewed fix.