Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329246 - OpenBreakpointMarkerAction class gets the Editor ID and then doesn't consider it when opening the editor
Summary: OpenBreakpointMarkerAction class gets the Editor ID and then doesn't consider...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 06:17 EDT by Antoaneta Petrova CLA
Modified: 2011-05-06 17:34 EDT (History)
5 users (show)

See Also:
pawel.1.piech: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoaneta Petrova CLA 2010-11-02 06:17:20 EDT 
Build Identifier: 20100617-1415

Invoking run() method of the OpenBreakpointMarkerAction class takes the target editor id, but the doesn't use it. It just calls WorkbenchPage .openEditor(IEditorInput input, String editorId) method, which then calls openEditor(final IEditorInput input,final String editorID, final boolean activate, final int matchFlags) and uses MATCH_INPUT constant, therefore the editor id, which is specified, is no longer considered. This ends with opening the wrong editor for the breakpoint marker.




Reproducible: Always

Steps to Reproduce:
Invoking run() method of the OpenBreakpointMarkerAction class takes the target editor id, but the doesn't use it. It just calls WorkbenchPage .openEditor(IEditorInput input, String editorId) method, which then calls openEditor(final IEditorInput input,final String editorID, final boolean activate, final int matchFlags) and uses MATCH_INPUT constant, therefore the editor id, which is specified, is no longer considered. This ends with opening the wrong editor for the breakpoint marker.
Comment 1 Darin Wright CLA 2010-11-02 09:50:08 EDT 
The API being used on IWorkbench page will re-use an existing editor if one is already open on the same editor input. We could call an alternate API that opens a new editor based on the editor input and editor ID.
Comment 2 Darin Wright CLA 2010-11-02 11:03:12 EDT 
Fixed in HEAD.
Comment 3 Pawel Piech CLA 2011-05-06 17:34:01 EDT 
Reviewed.