Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329245 - Variable 'flags' in UnixFileNatives is never used
Summary: Variable 'flags' in UnixFileNatives is never used
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 329281 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-02 06:05 EDT by Tomasz Zarna CLA
Modified: 2010-11-03 08:29 EDT (History)
3 users (show)

See Also:

Attachments
Fix v01 (951 bytes, patch)
2010-11-02 06:06 EDT, Tomasz Zarna CLA 		no flags Details | Diff
Patch_02 (886 bytes, patch)
2010-11-03 05:07 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2010-11-02 06:05:45 EDT 
It looks that variable 'flags' in org.eclipse.core.internal.filesystem.local.unix.UnixFileNatives is never used. Guys, is it safe to remove it? A patch doing that attached.
Comment 1 Tomasz Zarna CLA 2010-11-02 06:06:10 EDT 
Created attachment 182196 [details]
Fix v01
Comment 2 Szymon Brandys CLA 2010-11-03 04:32:37 EDT 
*** Bug 329281 has been marked as a duplicate of this bug. ***
Comment 3 Pawel Pogorzelski CLA 2010-11-03 05:07:48 EDT 
Created attachment 182275 [details]
Patch_02

It's better to OR the flag with previous value not to wipe off other attributes.

Couldn't come up with a test since the change can't be detected via EFS API. We simply don't support the attributes that were erased during the operation.
Comment 4 Szymon Brandys CLA 2010-11-03 08:29:24 EDT 
The fix is in HEAD. Thanks Pawel.