Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329169 - feature build.properties loaded repeatedly
Summary: feature build.properties loaded repeatedly
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 minor (vote)
Target Milestone: 3.7 M7   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-10-31 21:00 EDT by Jeff McAffer CLA
Modified: 2011-03-24 17:04 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2010-10-31 21:00:15 EDT 
In BuildDirector.computeElements() it looks like the build.properties for the current feature is repeatedly loaded by calling 
   			Properties featureProperties = getBuildProperties(feature);
inside the for loop iterating over the contents of the feature.  The build.properties for the feature should not change during the build (at least not while the feature is being processed) so a small performance improvement could be had by moving that line to before the for loop.
Comment 1 Andrew Niefer CLA 2011-03-24 17:04:36 EDT 
fixed