Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329142 - BuildCommand #equals is wrong leading to loss of Builders with custom triggers
Summary: BuildCommand #equals is wrong leading to loss of Builders with custom triggers
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 329143
  Show dependency tree
 
Reported: 2010-10-30 12:59 EDT by James Blackburn CLA
Modified: 2010-11-01 17:51 EDT (History)
0 users

See Also:
john.arthorne: review+

Attachments
test + fix 1 (4.09 KB, patch)
2010-10-30 12:59 EDT, James Blackburn CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2010-10-30 12:59:16 EDT 
Created attachment 182102 [details]
test + fix 1

The BuildCommand #equals and #hashCode consider the full value in BuildCommand#trigger.  As there are some meta bits used in trigger (for MASK_CONFIGURABLE, MASK_CONFIG_COMPUTED) #equals may yield false even if the two ICommands are equivalent.

The result is that the currently active builder state can be lost during #setBuildSpec.

Simple test + fix attached.
Comment 1 John Arthorne CLA 2010-11-01 17:50:53 EDT 
Looks good. Thanks James. I have released this to HEAD, but *not* for the I-build tomorrow so we can run some nightly builds before it goes out.