Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 329133 - Better Exception message for lock conflicts
Summary: Better Exception message for lock conflicts
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Martin Fluegge CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard: Lighter, Faster and Better
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-30 07:10 EDT by Eike Stepper CLA
Modified: 2011-06-23 03:39 EDT (History)
0 users

See Also:
stepper: review+

Attachments
Patch v1 (1.30 KB, patch)
2010-11-09 13:04 EST, Martin Fluegge CLA 		no flags Details | Diff
Patch v2 (3.65 KB, patch)
2010-11-13 03:17 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2010-10-30 07:10:46 EDT 
[ERROR] Conflict with org.eclipse.emf.cdo.internal.common.id.CDOIDRevisionDeltaLockWrapper@643cb077
org.eclipse.net4j.util.concurrent.TimeoutRuntimeException: Conflict with org.eclipse.emf.cdo.internal.common.id.CDOIDRevisionDeltaLockWrapper@643cb077
	at org.eclipse.net4j.util.concurrent.RWLockManager.lock(RWLockManager.java:304)
	at org.eclipse.net4j.util.concurrent.RWLockManager.lock(RWLockManager.java:117)
	at org.eclipse.emf.cdo.internal.server.TransactionCommitContext.lockObjects(TransactionCommitContext.java:746)
	at org.eclipse.emf.cdo.internal.server.TransactionCommitContext.write(TransactionCommitContext.java:388)
Comment 1 Martin Fluegge CLA 2010-11-09 13:04:58 EST 
Created attachment 182739 [details]
Patch v1

Well, because the description was a bit short I am not sure whether you only meant the message or also preferred a change the type of the Exception class. 

Because it is easier to fix I assumed you had the first case in mind ;)
Comment 2 Eike Stepper CLA 2010-11-13 03:17:02 EST 
Created attachment 183072 [details]
Patch v2

No, I really meant to add a nice toString() method to the wrapper class ;-)
Comment 3 Martin Fluegge CLA 2010-11-13 04:42:42 EST 
Patch v2 committed to HEAD.
Comment 4 Eike Stepper CLA 2011-06-23 03:39:05 EDT 
Available in R20110608-1407