Description Gerhard Leonhartsberger 2010-10-28 16:22:53 EDT

Build Identifier: M20100909-0800

NewProjectCreationOperation cannot be executed in a non UI thread because openFile(IFile) calls PDEPlugin.getActiveWorkbenchWindow() which returns null when invoked from a non UI thread. Please see the current code fragment of NewProjectCreationOperation that comes with Eclipse 3.6.1:

private void openFile(final IFile file) {
  final IWorkbenchWindow ww = PDEPlugin.getActiveWorkbenchWindow();
  final IWorkbenchPage page = ww.getActivePage();
  if (page == null)
	return;
  final IWorkbenchPart focusPart = page.getActivePart();
  ww.getShell().getDisplay().asyncExec(new Runnable() {
    public void run() {
      if (focusPart instanceof ISetSelectionTarget) {
        ISelection selection = new StructuredSelectionfile);
        ((ISetSelectionTarget) focusPart).selectReveal(selection);
      }
      try {
        IDE.openEditor(page, file, true);
      } catch (PartInitException e) {
      }
    }
  });
}

The implementation of openFile(IFile) should be changed as shown below:

private void openFile(final IFile file) {

  PDEPlugin.getDefault().getWorkbench().getDisplay().asyncExec(new Runnable() {
    public void run() {
      final IWorkbenchWindow ww = PDEPlugin.getActiveWorkbenchWindow();
      final IWorkbenchPage page = ww.getActivePage();
      if (page == null)
	return;
      final IWorkbenchPart focusPart = page.getActivePart();
      if (focusPart instanceof ISetSelectionTarget) {
        ISelection selection = new StructuredSelectionfile);
        ((ISetSelectionTarget) focusPart).selectReveal(selection);
      }
      try {
        IDE.openEditor(page, file, true);
      } catch (PartInitException e) {
      }
    }
  });
}


Reproducible: Always

Steps to Reproduce:
as mentioned above