Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328957 - EJB Client JAR is missing under Bundle Lib node of an EAR project
Summary: EJB Client JAR is missing under Bundle Lib node of an EAR project
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-28 14:12 EDT by Petya Sabeva CLA
Modified: 2010-11-10 12:04 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (1.08 KB, patch)
2010-11-05 14:44 EDT, Aidyl Kareh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petya Sabeva CLA 2010-10-28 14:12:41 EDT 
Build Identifier: I20101027-1800

Create one EAR 1.5 project. Create one EJB 3.0 with EJB Client Jar project and add it to the created EAR project. Expand the deployment descriptor tree of the EAR project. The EJB Client Jar should be under Bundle Lib node of the deployment descriptor tree of the EAR project, but it is missing.

Reproducible: Always
Comment 1 Carl Anderson CLA 2010-10-29 00:17:14 EDT 
Assigning to Kaloyan for initial investigation.  Please reassign and/or retarget as appropriate.

I was able to reproduce this problem.
Comment 2 Carl Anderson CLA 2010-11-05 11:55:53 EDT 
This is a side effect of the changes made for bug 328092 - most notably, the check in AbstractEarNode.getComponentReferencesAsList() if(!relativeRuntimePath.isEmpty()
Comment 3 Aidyl Kareh CLA 2010-11-05 14:44:11 EDT 
Created attachment 182511 [details]
Proposed Patch

Patch removes the !relativeRuntimePath.isEmpty() check in the AbstractEarNode.getComponentReferencesAsList() method. Removing this check fixes the issue. Check was added to handle the scenario where an empty lib dir is being used but this was the incorrect location to do it. This scenario is already covered by the AbstractEarNode.getModules() method later on.
Comment 4 Chuck Bridgham CLA 2010-11-08 10:25:30 EST 
approved
Comment 5 Jason Sholl CLA 2010-11-10 12:04:53 EST 
Code checked into both 32M and HEAD for WTP 3.2.3 and 3.3