Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328922 - virgo snaps menu-bar sample does not work
Summary: virgo snaps menu-bar sample does not work
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Glyn Normington CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-28 09:09 EDT by Patsy Phelan CLA
Modified: 2010-10-28 10:36 EDT (History)
1 user (show)

See Also:

Attachments
Git Patch Set for fix. (2.82 KB, patch)
2010-10-28 09:11 EDT, Patsy Phelan CLA 		glyn.normington: iplog+
Details | Diff
Plan file for the Menu-Bar sample. (675 bytes, text/plain)
2010-10-28 09:14 EDT, Patsy Phelan CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patsy Phelan CLA 2010-10-28 09:09:36 EDT 
Build Identifier: Build id: I20100608-0911

As you try to run the menu-bar sample for snaps, it generates deployment errors on the console and does not load. These are due to merge conflicts of the images packages between the host (animal.menu.bar) and the snaps (cat.menu.item or dog.menu.item).

Reproducible: Always

Steps to Reproduce:
1.Load Virgo Snaps plan into the virgo server.
2.Load a plan which encompasses the menu-bar sample (3 bundles, animal.menu.bar and cat/dog.menu.item)
3.
Comment 1 Patsy Phelan CLA 2010-10-28 09:11:03 EDT 
Created attachment 181933 [details]
Git Patch Set for fix.

The fix is to update the bundlor template to exclude the images package in the manifest of the snaps bundles. You must also update the MANIFEST.MF itself.
Comment 2 Patsy Phelan CLA 2010-10-28 09:12:23 EDT 
I confirm that i have written 100% of the attached patch and that
i'm allowed to contribute the patch to eclipse.org.
Comment 3 Patsy Phelan CLA 2010-10-28 09:14:09 EDT 
Created attachment 181934 [details]
Plan file for the Menu-Bar sample.

Simple Plan file for deployment of the menu-bar sample.
Comment 4 Glyn Normington CLA 2010-10-28 10:36:24 EDT 
Thanks for this patch. Applied in commit 72af32cc6ee51a146b37773fecdfb03fbe12d81a and pushed.