Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328897 - Thread leak when a debug session exits
Summary: Thread leak when a debug session exits
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Debug UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 19:14 EDT by Justin Kong CLA
Modified: 2011-05-14 06:46 EDT (History)
0 users

See Also:

Attachments
Patch (740 bytes, patch)
2010-10-27 19:16 EDT, Justin Kong CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Kong CLA 2010-10-27 19:14:19 EDT 
Build Identifier: 

When a parallel debug session terminates or runs to completion, AbstractProxyDebugClient.doShutdown is called. Any thread that enters this method can only exit when the current state of the AbstractProxyDebugClient is set to DISCONNECTED. This only occurs when another thread calls AbstractProxyDebugClient.doShutdown a second time.

In PTP 5.0, #doShutdown is only called once, and thus, every time a debug session finishes, a thread is leaked. The change that caused this is in Session.shutdown, as debugger.stopDebugger is no longer called.

Reproducible: Always
Comment 1 Justin Kong CLA 2010-10-27 19:16:13 EDT 
Created attachment 181897 [details]
Patch

Simple fix that just adds debugger.stopDebugger back to Session.shutdown.
Comment 2 Greg Watson CLA 2010-12-07 15:44:25 EST 
Applied to HEAD. Thanks!