Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328892 - [formatting] FormattingStrategyJSDT needs to react to SSE formatting changes
Summary: [formatting] FormattingStrategyJSDT needs to react to SSE formatting changes
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.2.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 17:35 EDT by Ian Tewksbury CLA
Modified: 2010-10-27 19:16 EDT (History)
0 users

See Also:
thatnitind: review+

Attachments
Fix Patch with JUnits (15.90 KB, patch)
2010-10-27 17:37 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2010-10-27 17:35:58 EDT 
The SSE bug 203252 changed the way web pages are formatted.  The side affect to JSDT is that now script tags are indented when under the body tag.  The FormattingStrategyJSDT needs to be updated to calculate the indent level of the script tag preceding the JS region and indent the entire region at least that amount.  All corresponding JUnits need to be updated as well.
Comment 1 Ian Tewksbury CLA 2010-10-27 17:37:32 EDT 
Created attachment 181888 [details]
Fix Patch with JUnits

Fix patch to fix up the FormattingStrategyJSDT as described in the bug description as well as updated to the corresponding JUnits.
Comment 2 Nitin Dahyabhai CLA 2010-10-27 18:42:56 EDT 
Committed, thanks, Ian.
Comment 3 Nitin Dahyabhai CLA 2010-10-27 19:16:50 EDT 
Released to 3.2.3 and HEAD.