Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328858 - [inline] Inline operations fail when files are read-only
Summary: [inline] Inline operations fail when files are read-only
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 12:21 EDT by Robert Konigsberg CLA
Modified: 2020-01-07 14:06 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Konigsberg CLA 2010-10-27 12:21:35 EDT
Build Identifier: M20100211-1343

I'm trying to do a large scale refactoring by inlining a method call. The inline is pretty simple in-and-of-itself:

/** @deprecated use {@code getInner().foo(); } */
public Bar foo() {
  return getInner().foo();
}

I told the inline operation to not remove foo() itself; I'm just hoping it will inline as many operations as possible.

The refactoring engine finds lots of uses, it even tells me about references it will disregard; references in class file, and "invalid references" (whatever those are.)

So the engine is smart enough to know that it can't catch all of the references to inline.

But when it comes across a read-only file, the entire inlining operation fails.

Reproducible: Always
Comment 1 Olivier Thomann CLA 2010-10-27 12:47:38 EDT
Move to JDT/UI
Comment 2 Robert Konigsberg CLA 2010-10-27 12:55:31 EDT
I always forget refactoring is in UI.
Comment 3 Markus Keller CLA 2011-01-06 06:00:48 EST
Deepak, could you please have a look?
Comment 4 Eclipse Genie CLA 2020-01-07 14:06:36 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.