Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328850 - BestMatchHover needs to support ITextHoverExtension2
Summary: BestMatchHover needs to support ITextHoverExtension2
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M3   Edit
Assignee: Michael Rennie CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 313015
  Show dependency tree
 
Reported: 2010-10-27 11:46 EDT by Michael Rennie CLA
Modified: 2015-09-23 12:05 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
proposed fix (10.72 KB, patch)
2010-10-27 11:46 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-10-27 11:46:08 EDT 
Created attachment 181848 [details]
proposed fix

code from HEAD

While trying to fix bug 313015, I found that I cannot return an Object to open a hover control on like we did for JDT. The reason for this is that BestMatchHover /AbstractJavaEditorTextHover (the JavaScript variant) does not support ITextHoverExtension2.

The attached patch adds support to the JS hovers for ITextHoverExtension2 (and allows the fix for bug 313015 to work)
Comment 1 Nitin Dahyabhai CLA 2010-10-27 13:24:36 EDT 
Sounds like a nice addition.
Comment 2 Michael Rennie CLA 2010-11-01 14:04:33 EDT 
applied patch to HEAD
Comment 3 Angelo ZERR CLA 2015-09-23 12:05:23 EDT 
I don't understand, it seems that current JSDT version doesn't support ITextHoverExtension2 . If you see http://git.eclipse.org/c/jsdt/webtools.jsdt.git/tree/bundles/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/text/java/hover/AbstractJavaEditorTextHover.java this class doesn't implement ITextHoverExtension2  although this issue fix that?

In my case I need that for tern.java because without this support, the tern hover popup is too small.

Many thanks's for your help.