Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328798 - IResourceServiceProvider.Registry is accessed directly
Summary: IResourceServiceProvider.Registry is accessed directly
Status: CLOSED WONTFIX
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 04:31 EDT by Ali AKAR CLA
Modified: 2012-11-19 08:34 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali AKAR CLA 2010-10-27 04:31:27 EDT 
Build Identifier: tmf-xtext-SDK-1.0.1

If you try to override the IResourceServiceProvider.Registry which is implemented by ResourceServiceProviderRegistryImpl by overridden the SharedModule , your instance will be called but not initialized by the extension and the content registry reader (ExtensionResourceServiceProviderRegistryReader). In both readers, the the singleton is accessed directly, where it should be injected instead.


Reproducible: Always
Comment 1 Sven Efftinge CLA 2012-11-19 08:34:54 EST 
It's now done in the activator of org.eclispe.xtext, where no injector is available. Also replacing the registry implementation doesn't seem to be a good idea.