Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328796 - [tcf agent] missing some environment variables in launching bash in terminals service
Summary: [tcf agent] missing some environment variables in launching bash in terminals...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.4.0   Edit
Assignee: Project Inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 03:53 EDT by Lianhao Lu CLA
Modified: 2013-06-05 07:56 EDT (History)
6 users (show)

See Also:

Attachments
patch to add necessary environment variables (5.65 KB, patch)
2010-10-27 04:00 EDT, Lianhao Lu CLA 		eugene: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lianhao Lu CLA 2010-10-27 03:53:30 EDT 
Build Identifier: 

In current implementation of terminals service in tcf agent (revision 1204), when configured to launch the bash directly instead of login, some environment variables are missing, i.e. USER, LOGNAME, HOME, etc. This could make the bash launched less user friendly. 

Reproducible: Always
Comment 1 Lianhao Lu CLA 2010-10-27 04:00:27 EDT 
Created attachment 181804 [details]
patch to add necessary environment variables

This patch added the necessary environment variables and changes the default launching application of terminals service from login to bash
Comment 2 Anna Dushistova CLA 2010-11-04 05:58:26 EDT 
Comment on attachment 181804 [details]
patch to add necessary environment variables

Eugene, could you please review the patch?
Thanks!
Comment 3 Eugene Tarassov CLA 2010-11-04 14:30:51 EDT 
(In reply to comment #2)
> (From update of attachment 181804 [details])
> Eugene, could you please review the patch?
> Thanks!

It looks OK. Tests passed OK. I have committed the patch.
Thanks!
Comment 4 Doug Schaefer CLA 2011-05-17 10:48:22 EDT 
Moving bugs to new home for IP log.
Comment 5 Martin Oberhuber CLA 2013-06-05 06:25:27 EDT 
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3