Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328770 - e4 cocoa fragment is out of date with E3.x fragment
Summary: e4 cocoa fragment is out of date with E3.x fragment
Status: CLOSED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 15:35 EDT by Brian de Alwis CLA
Modified: 2011-12-12 11:37 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2010-10-26 15:35:05 EDT 
There have been a number of features added to the E3.x fragment that have not been reflected in the e4 variant.  

The e4 variant was originally intended to make the system menu integration available to pure e4 apps.  It's unclear what should happen if there are changes that properly belong in the org.eclipse.ui land.
Comment 1 Brian de Alwis CLA 2011-03-03 14:59:03 EST 
This bug follows on bug 328755.

With the new SWT Display.getSystemMenu() APIs (bug 338825 and bug 329456), we should see if there's a way to allow the pure e4.workbench.renderer.swt.cocoa fragment to co-exist with the E3.x ui.cocoa fragment.

The e4 fragment does two things: (1) it handles selections from the pillbox (upper-right on windows), and (2) it remaps the About, Preferences, and Quit items.  When any of these elements are selected, it invokes an appropriate command through the e4 command service.

It's possible that if the e4 and E3.x cocoa bits are loaded simultaneously, then we'll have two listeners for About, Preferences, and Quit.

One possibility would be to use a a system property for the two bits to communicate whether the mapping has been done?

Alternatively one could check to see if the other bundle is available and loaded.  I think this might be my preference.
Comment 2 Brian de Alwis CLA 2011-12-12 11:37:57 EST 
These changes were made Wed Apr 27, 2011 in commit 'a58d957a4eab69da0d8411b78892e38fc6b3820e'.