Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328756 - e4 tooling should move to git
Summary: e4 tooling should move to git
Status: CLOSED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 14:22 EDT by Lars Vogel CLA
Modified: 2012-05-14 17:04 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2010-10-26 14:22:02 EDT
It would be good IMHO if the tooling (Toms Editor and the wizards) could be moved to git.
Comment 1 Thomas Schindl CLA 2010-11-05 07:30:32 EDT
I'm +1 on this - I'll prepare a list of bundles we'd need to move.
Comment 2 Lars Vogel CLA 2010-11-05 09:54:31 EDT
Cool. I hope this will help others (including myself) to help out in the tooling area.
Comment 3 Paul Webster CLA 2011-06-12 11:51:33 EDT
With the work being done in bug 345471 and bug 345479 post 4.1/0.11 might be the ideal time to do it, or at least organize what must be moved.

PW
Comment 4 Thomas Schindl CLA 2011-06-12 13:11:41 EDT
Like stated before I'd really welcome moving to git. What we should consider is that the e4 brigde we talked about to leverage in 4.2 to refactor some of our ui.workbench-code is currently developed as part of the tooling effort.

Beside that I really hope that we'll push the e4 tooling forward more in 4.2 so that it can graduate. PDE could be a potential candidate but to make that happen I need help from others because I simply don't have enough resources.
Comment 5 Thomas Schindl CLA 2011-06-12 13:13:29 EDT
A component I'd like to add in 4.2 here is an CSS-Editor written using Xtext. I already wrote one just the other day for my JavaFX-work. 

Maybe it could even replace the batik and css stuff we currently consume from Orbit?
Comment 6 Paul Webster CLA 2011-06-13 07:41:22 EDT
(In reply to comment #5)
> A component I'd like to add in 4.2 here is an CSS-Editor written using Xtext. I
> already wrote one just the other day for my JavaFX-work. 

CSS editing support seems to make sense to me in 4.2/0.12.  But the batik stuff doesn't supply an editor, it's about multiple CSS stylesheet processing IIRC.

PW
Comment 7 Thomas Schindl CLA 2011-06-13 07:54:17 EDT
... but if you write an editor using Xtext you naturally also get a parser genersted because all Xtext does is to create an in memory EMF-Model from the textual representation ;-)
Comment 8 Paul Webster CLA 2011-06-13 10:26:51 EDT
(In reply to comment #7)
> ... but if you write an editor using Xtext you naturally also get a parser
> genersted because all Xtext does is to create an in memory EMF-Model from the
> textual representation ;-)

But it's not just the parser ... it's the knowledge that when you ask for .body "here" you get one definition, but when you ask for .body "somewhere-else" you get a hierarchical .body definition because it read some parent stylesheets as well.

PW
Comment 9 Nitin Dahyabhai CLA 2011-06-13 13:15:00 EDT
(In reply to comment #5)
> A component I'd like to add in 4.2 here is an CSS-Editor written using Xtext. I
> already wrote one just the other day for my JavaFX-work.

Wouldn't that conflict with the one we've had in WTP since '04?  Is it not worth just adding onto that editor in some way?
Comment 10 Paul Webster CLA 2011-06-29 07:30:18 EDT
I've created a test repo at git://git.eclipse.org/e4/org.eclipse.e4.tools.git

PW
Comment 11 Paul Webster CLA 2011-06-29 07:41:00 EDT
(In reply to comment #10)
> I've created a test repo at git://git.eclipse.org/e4/org.eclipse.e4.tools.git

git://git.eclipse.org/gitroot/e4/org.eclipse.e4.tools.git
Comment 12 Paul Webster CLA 2011-07-06 14:16:58 EDT
OK, I've created a real tools git repo.

git://git.eclipse.org/gitroot/e4/org.eclipse.e4.tools.git

I have not converted the map file yet to use the new repo, but any new changes you wish to contribute should go here.

PW
Comment 13 Paul Webster CLA 2011-07-07 16:43:06 EDT
technically post 4.1 and in 0.12
PW
Comment 14 Lars Vogel CLA 2012-05-14 17:04:04 EDT
Fixed long time ago.