Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328727 - Compare editor in commit dialog should allow edit file before commit
Summary: Compare editor in commit dialog should allow edit file before commit
Status: CLOSED WONTFIX
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.10.0   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 11:24 EDT by Andrew Gvozdev CLA
Modified: 2013-09-27 11:58 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gvozdev CLA 2010-10-26 11:24:57 EDT 
There is a compare editor available in commit dialog on doubleclick. There are 2 problems with that:
1. There is no any clue for a user that it is available.
2. Compare editor does not let editing the file before commit.
Comment 1 Stefan Lay CLA 2010-10-27 03:19:03 EDT 
I fully agree. We should do that.
Comment 2 Robin Stocker CLA 2013-09-27 11:58:39 EDT 
(In reply to Andrew Gvozdev from comment #0)
> 1. There is no any clue for a user that it is available.

Please see bug 321018.

> 2. Compare editor does not let editing the file before commit.

I don't think we should add that to the commit dialog. It's already possible with the "Git Staging" view, which also has many other advantages over the commit dialog.