Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328683 - Context configuration should not be copied to configuration directory
Summary: Context configuration should not be copied to configuration directory
Status: CLOSED FIXED
Alias: None
Product: Gemini.Web
Classification: RT
Component: unknown (show other bugs)
Version: 1.1.0.RELEASE   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 2.0.0.M01   Edit
Assignee: Violeta Georgieva CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 332042
Blocks:
  Show dependency tree
 
Reported: 2010-10-26 06:02 EDT by Glyn Normington CLA
Modified: 2011-05-24 00:02 EDT (History)
0 users

See Also:
glyn.normington: review+

Attachments
Patch (6.73 KB, patch)
2011-05-19 03:04 EDT, Violeta Georgieva CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2010-10-26 06:02:09 EDT 
There are some fairly serious limitations in the current context configuration support.

If a user provides META-INF/context.xml inside an archive, then this is copied to the relevant place in the configuration directory. Subsequent deployments of the application will use the context configuration from the configuration directory, which may not match the content of META-INF/context.xml.

There is also a general issue that the configuration directory should be under the user's control and should not be updated by Gemini Web.

Given the imminent release of Gemini Web, I'll document a known issue in the Virgo User Guide pointing to this bug and we can fix this bug in a subsequent release such as 1.1.1.
Comment 1 Glyn Normington CLA 2010-10-26 11:26:52 EDT 
A partial workaround is to delete the copy of the file (e.g. $SERVER_HOME/config/[enginename]/[hostname]/[contextpath].xml) before redeploying the application.
Comment 2 Glyn Normington CLA 2011-05-16 11:48:43 EDT 
This bug has an assignee, so changing status to ASSIGNED.
Comment 3 Violeta Georgieva CLA 2011-05-18 09:15:06 EDT 
With migration to Tomcat 7 now we can introduce such switch. See TODO comment
in org.eclipse.gemini.web.tomcat.internal.WebappConfigLocator.resolveWebappContextXml(String, String, File) method.
Comment 4 Violeta Georgieva CLA 2011-05-19 03:04:31 EDT 
Created attachment 196074 [details]
Patch
Comment 5 Glyn Normington CLA 2011-05-19 07:29:32 EDT 
The patch looks good.
Comment 6 Violeta Georgieva CLA 2011-05-19 08:16:41 EDT 
Change is tested, committed and pushed.
Commit Id: 5f7547194bf220e32baf47086d44be39cce32004
Comment 7 Glyn Normington CLA 2011-05-19 10:19:05 EDT 
Note 1.2.0.M05 may become 2.0.0.M01 if bug 346408 is implemented before the milestone.