Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328643 - Constructor for org.eclipse.help.base.remote.RemoteIC has incorrect variable assignment
Summary: Constructor for org.eclipse.help.base.remote.RemoteIC has incorrect variable ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Jim Perry CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-25 14:03 EDT by Jim Perry CLA
Modified: 2010-10-26 15:52 EDT (History)
1 user (show)

See Also:

Attachments
Patch with the unneeded variable assignment (788 bytes, patch)
2010-10-25 14:05 EDT, Jim Perry CLA 		no flags Details | Diff
Patch with fix for this.protocol (829 bytes, patch)
2010-10-25 14:15 EDT, Jim Perry CLA 		ChrisAustin: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Perry CLA 2010-10-25 14:03:44 EDT 
Build Identifier: N20101023-2000

In the class org.eclipse.help.base.remote.RemoteIC, there is an incorrect assignment of this.port to the string HTTP_PROTOCOL.  This must have been put there when we upgraded to support HTTPS protocol.

public RemoteIC(boolean enabled, String name, String host, String path, String port){
		
    	this.enabled = enabled;
	this.name    = name;
	this.host    = host;
	this.path    = path;
	this.port    = port;
	this.port    = PROTOCOL_HTTP;
}


The final line should be removed.

Reproducible: Always

Steps to Reproduce:
1. Open the class org.eclipse.help.base.remote.RemoteIC
2. Inspect the first constructor for the un-needed this.port variable assingment.
3.
Comment 1 Jim Perry CLA 2010-10-25 14:05:12 EDT 
Created attachment 181672 [details]
Patch with the unneeded variable assignment
Comment 2 Jim Perry CLA 2010-10-25 14:15:27 EDT 
Created attachment 181675 [details]
Patch with fix for this.protocol

Instead of removing the line, it should look like this

 this.protocol    = PROTOCOL_HTTP;


Instead of:

 this.port    = PROTOCOL_HTTP;
Comment 3 Chris Austin CLA 2010-10-26 15:52:34 EDT 
Patch committed to HEAD.