Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328635 - allow connectors to hide kind in tooltip
Summary: allow connectors to hide kind in tooltip
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 trivial (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-25 12:49 EDT by Thomas Ehrnhoefer CLA
Modified: 2011-02-05 16:51 EST (History)
2 users (show)

See Also:

Attachments
patch (2.14 KB, patch)
2010-10-25 12:58 EDT, Thomas Ehrnhoefer CLA 		thomas.ehrnhoefer: review?
Details | Diff
mylyn/context/zip (12.84 KB, application/octet-stream)
2010-10-25 12:58 EDT, Thomas Ehrnhoefer CLA 		no flags Details
patch (3.34 KB, patch)
2010-10-26 07:57 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (13.78 KB, application/octet-stream)
2010-10-26 07:57 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2010-10-25 12:49:38 EDT 
The taskKind label is always shown (if taskKind is set on the task and the taskKind is not the same as the task label).
That means that if a connector adds custom label for it's task kinds, in order to not have redundant information (e.g. @Feature xy (feature)@) it would need to use the same string for label and taskKind.
This is a bit odd as an identifier for a taskKind is static, but a label can be dynamic (e.g. i18n).
Comment 1 Thomas Ehrnhoefer CLA 2010-10-25 12:58:02 EDT 
Created attachment 181662 [details]
patch

Here is a patch.
Although while thinking more about this, maybe it is useful to show the task kind if the label is different. That would mean that with an internationalized label, it is still possible to see the connector internal task kind....

I am a bit torn now, not sure what's best
Comment 2 Thomas Ehrnhoefer CLA 2010-10-25 12:58:04 EDT 
Created attachment 181663 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2010-10-26 07:57:57 EDT 
Created attachment 181710 [details]
patch
Comment 4 Steffen Pingel CLA 2010-10-26 07:57:59 EDT 
Created attachment 181711 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2010-10-26 07:58:36 EDT 
I agree that the API need improvement. Implementations of AbstractRepositoryConnectorUi.getTaskKindLabel(ITask) commonly return a static label which is why the tooltip now also shows the task kind but as you point out those values are not necessarily suitable to be displayed in the UI.

I think we need a more flexible solution that allows proper customization and internationalization of the label. What do you think about delegating to the connector UI to provide the entire label?
Comment 6 Thomas Ehrnhoefer CLA 2010-10-26 12:06:34 EDT 
(In reply to comment #5)
> I think we need a more flexible solution that allows proper customization and
> internationalization of the label. What do you think about delegating to the
> connector UI to provide the entire label?

Probably best.
Comment 7 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn