Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328614 - Decrease direct field access in preparation for CDO
Summary: Decrease direct field access in preparation for CDO
Status: CLOSED FIXED
Alias: None
Product: STEM
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.1.2   Edit
Assignee: Matthew Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-25 10:44 EDT by Tero Parviainen CLA
Modified: 2012-01-20 19:37 EST (History)
2 users (show)

See Also:


Attachments
Patch against trunk, r1110 (128.30 KB, patch)
2010-10-25 10:44 EDT, Tero Parviainen CLA
sedlund: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tero Parviainen CLA 2010-10-25 10:44:05 EDT
Created attachment 181643 [details]
Patch against trunk, r1110

The attached patch replaces most of internal field access in EMF models with getter/setter calls.

The changes only affect class internals, no APIs have changes.
Comment 1 Matthew Davis CLA 2010-10-26 18:25:16 EDT
Thanks Tero for the patch.  Assigning to myself to evaluate for inclusion.
Comment 2 Matthew Davis CLA 2010-10-29 16:54:02 EDT
Thanks again, Tero, for the contribution.

I have reviewed the patch and can confirm that it complies with Eclipse
conventions and does not contain any items (cryptography) that require
additional approvals.

Tero, please confirm again:
1) The code contributed was authored by you alone
2) That you have permission to submit this code to Eclipse (we have your
contribution form on record, this is just a confirmation).
Comment 3 Tero Parviainen CLA 2010-10-30 04:21:58 EDT
> Tero, please confirm again:
> 1) The code contributed was authored by you alone
> 2) That you have permission to submit this code to Eclipse (we have your
> contribution form on record, this is just a confirmation).

I confirm both points.
Comment 4 Matthew Davis CLA 2010-11-01 15:34:19 EDT
Patch applied to the trunk and committed at revision 1123.

The following projects were affected:

org.eclipse.stem.core
org.eclipse.stem.definitions
org.eclipse.stem.diseasemodels
org.eclipse.stem.diseasemodels.experimental
org.eclipse.stem.diseasemodels.forcing
org.eclipse.stem.diseasemodels.multipopulation
org.eclipse.stem.graphgenerators
org.eclipse.stem.internal.data
org.eclipse.stem.populationmodels
org.eclipse.stem.solvers.rk
org.eclipse.stem.tests.util

Thanks again, Tero.
Comment 5 Matthew Davis CLA 2010-11-01 15:34:49 EDT
Marking as resolved for inclusion in IP Log
Comment 6 James Kaufman CLA 2011-07-18 21:42:52 EDT
Complete