Description Peer Törngren 2010-10-25 02:16:52 EDT

Build Identifier:  20100617-1415

For accessibility and general usability reasons, I wish to map some keys to handle "move row" on the grid. The grid uses "UP/DOWN" with CTRL or SHIFT to do select and focus operations, and the plain keys (without modifiers) to do traversal. Since the ALT+UP/DOWN keys are unused by the grid, I thought I'd use these. 


Alas, the way that the grid listens to key events prevents this; it does special handling of both CTRL and SHIFT, and defaults to "traversal". I can add the key listener and have it do what I want, but cannot prevent the traversal operation. Also, since the Grid gets notified first, I cannot "consume" the event by setting "KeyEvent.doit" to false. I can get the desired behavior by using other keys (e.g. ALT+NUMPAD_8 and ALT+NUMPAD_2).

The problem seems to be located to org.eclipse.nebula.widgets.grid.Grid.onKeyDown(Event), where the UP/DOWN key behaves the same way whether or not the ALT (MOD3) key is used. 

I can see two solutions:
a) make org.eclipse.nebula.widgets.grid.Grid.onKeyDown(Event) ignore keys if an undefined modifier (such as MOD3) is used
b) make Grid consume key events last in chain, allowing externally added listeners to prevent grid default actions by setting 'KeyEvent.doit=false'


Reproducible: Always

Steps to Reproduce:
1. Grid myGrid = new Grid(....)
2. myGrid.addKeyListener(new KeyListener(...) {
   public void keyPressed(KeyEvent e): 
       switch (e.keyCode) {
       case SWT.ARROW_UP:
           if ((e.stateMask & SWT.ALT) != 0) {
               doMyStuffInsteadOfTraversing();
               e.doit = false;
           }
	break;
<snip>