Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328521 - Add AccessibleListener and friends
Summary: Add AccessibleListener and friends
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.4 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 21:33 EDT by Elias Volanakis CLA
Modified: 2010-11-08 03:19 EST (History)
1 user (show)

See Also:


Attachments
Patch (15.52 KB, text/plain)
2010-10-22 21:35 EDT, Elias Volanakis CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Volanakis CLA 2010-10-22 21:33:40 EDT
Please add AccessibleListener, AccessibleEvent, AccessibleAdapter.

See attached patch.

This is needed to make single-sourcing easier. It does not create problems, because control.getAccessible() and the class Accessible are _not_ available. The user will still get compile errors to alert him. However writing a facade is easier, since the events and listeners can be kept in the single-sourced code.
Comment 1 Elias Volanakis CLA 2010-10-22 21:35:00 EDT
Created attachment 181567 [details]
Patch
Comment 2 Elias Volanakis CLA 2010-10-26 16:47:58 EDT
Hi Ivan/RAP-team, 

could you review and commit the attached patch? I need it for my project.

Thanks,
Elias.
Comment 3 Ralf Sternberg CLA 2010-10-28 19:58:18 EDT
I'm reluctant to create an accessibility package in RWT. It is not clear if we can ever support the accessiblity API in RAP. Couldn't the accessibility listeners live in the RAP fragment as well?
Comment 4 Elias Volanakis CLA 2010-11-03 12:21:46 EDT
I would strongly prefer to have these classes.

When writing custom widgets (as we have in our app), the accessibility code in the listeners is tightly coupled with internal fields of the widget. Moving it to a fragment requires exposing a lot of internal state.

I don't see a problem adding those, since the relevant add/remove listener methods will still be missing. We have done likewise with other unsupported listeners in the past as well.
Comment 5 Ralf Sternberg CLA 2010-11-08 02:45:37 EST
Ok, if it really helps you, let's add them. I somehow wanted to avoid the accessibility package, but since I have no strong reasons for that, I agree.
Comment 6 Ivan Furnadjiev CLA 2010-11-08 03:19:01 EST
Applied patch to CVS HEAD.