Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328467 - double clicking on required features does not open feature
Summary: double clicking on required features does not open feature
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-10-22 08:50 EDT by Jeff McAffer CLA
Modified: 2013-11-01 07:25 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2010-10-22 08:50:40 EDT 
1) create a feature that *requires* another feature
2) double click on the requried feature
3) observe that nothing happens.
4) add an *included* feature
5) double click on the included feature
6) observe that that clicked feature is open in the feature editor
Comment 1 Marc-André Laperle CLA 2013-10-18 00:58:42 EDT 
Proposed patch:
https://git.eclipse.org/r/17509
Comment 2 Curtis Windatt CLA 2013-10-21 11:58:12 EDT 
There should be an Open command added to the context menu.  The change is good otherwise, it opens the editor in editable mode if the feature/plug-in is in the workspace.
Comment 3 Marc-André Laperle CLA 2013-10-21 14:12:25 EDT 
(In reply to Curtis Windatt from comment #2)
> There should be an Open command added to the context menu.  The change is
> good otherwise, it opens the editor in editable mode if the feature/plug-in
> is in the workspace.

OK I'll make it a command. I think there's somewhere else in the code that does that. Thank you for looking at it!
Comment 4 Marc-André Laperle CLA 2013-10-24 19:46:44 EDT 
I updated the patch.
Comment 5 Dani Megert CLA 2013-10-26 02:17:27 EDT 
(In reply to Marc-Andre Laperle from comment #4)
> I updated the patch.

I'm not sure the new patch is what Curtis meant. At least for me, the new action is just overkill unless it is also used at other places.
Comment 6 Curtis Windatt CLA 2013-10-29 14:47:01 EDT 
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d1b5044516b6143dab6e085edcefa9fda4ce6dbd
Fixed in master

Sorry that this is a little close to M3.
Comment 7 Marc-André Laperle CLA 2013-10-29 14:49:53 EDT 
Don't you mean, Target Milestone: 4.4 M3?

Thanks for applying the fix!
Comment 8 Dani Megert CLA 2013-11-01 07:25:06 EDT 
Verified in I20131030-2000.